Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address miscellaneous issues throughout code base #1257

Merged
merged 17 commits into from
Oct 11, 2023
Merged

Address miscellaneous issues throughout code base #1257

merged 17 commits into from
Oct 11, 2023

Commits on Oct 9, 2023

  1. misc: use Err prefix for errors 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    354a8e8 View commit details
    Browse the repository at this point in the history

  2. misc: remove redundant return statements 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    25400d8 View commit details
    Browse the repository at this point in the history

  3. misc: remove unnecessary use of fmt.Sprintf 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8d1c755 View commit details
    Browse the repository at this point in the history

  4. misc: properly handle f.Close() defer 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0288645 View commit details
    Browse the repository at this point in the history

  5. misc: ensure return errs are captured 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    691d925 View commit details
    Browse the repository at this point in the history

  6. misc: simplify by directly returning bool 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    3a0c279 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. misc: address k8s.io/utils/pointer deprecation 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    d56d0a7 View commit details
    Browse the repository at this point in the history

  2. misc: iotuil deprecation 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    0a27f6a View commit details
    Browse the repository at this point in the history

  3. misc: rand.Seed deprecation 

    See: https://pkg.go.dev/math/rand@go1.20#Seed

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    d9dbd1b View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. misc: math/rand.Read() has been deprecated 

    See: https://pkg.go.dev/math/rand@go1.20#Read

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    a74eb57 View commit details
    Browse the repository at this point in the history

  2. misc: address duplicate imports 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2023081 View commit details
    Browse the repository at this point in the history

  3. misc: add test case for invalid tag signature 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    cdb43f1 View commit details
    Browse the repository at this point in the history

  4. misc: remove unused code 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    a70b3f3 View commit details
    Browse the repository at this point in the history

  5. misc: remove redundant nil check 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    aba9800 View commit details
    Browse the repository at this point in the history

  6. misc: do not capitalize err string and fix wording 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b0d94ce View commit details
    Browse the repository at this point in the history

  7. misc: fix hypothetical implicit memory aliasing 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    04612b5 View commit details
    Browse the repository at this point in the history

  8. misc: set TLS certificate files perms to 0o600 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    09772bd View commit details
    Browse the repository at this point in the history