Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: change default file permissions #1276

Merged
merged 2 commits into from
Nov 6, 2023
Merged

storage: change default file permissions #1276

merged 2 commits into from
Nov 6, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Nov 3, 2023

No description provided.

@hiddeco hiddeco added enhancement New feature or request area/storage Storage related issues and pull requests labels Nov 3, 2023
@hiddeco
Copy link
Member Author

hiddeco commented Nov 3, 2023

@rashedkvm can you please confirm this does not create any issues with your usage of source-controller?

Copy link
Member

@rashedkvm rashedkvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiddeco this changes restricts group and public permission for file/directory/exe. Owner permission remain unchanged. I can't think of any issue at the moment. If you need to get this change in quickly, please proceed. Alternatively, I can test this change but requires sometime.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco marked this pull request as ready for review November 6, 2023 11:23
k8s.io/api v0.27.4
k8s.io/apimachinery v0.27.4
k8s.io/client-go v0.27.4
k8s.io/api v0.27.7
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remainder should be done in a separate PR, as this one is just about the storage changes.

As this includes an update of ORAS compatible with newer versions of
`github.com/docker/docker`, we can unpin this dependency.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco merged commit 3ab56ae into main Nov 6, 2023
9 checks passed
@hiddeco hiddeco deleted the default-file-perms branch November 6, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage Storage related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants