Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to cosign v2.2.4 #1442

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Update dependencies to cosign v2.2.4 #1442

merged 2 commits into from
Apr 11, 2024

Conversation

stefanprodan
Copy link
Member

Bump cosign to v2.2.4 and adapt tests to match the upstream bug fix in sigstore/cosign#3526

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added the dependencies Pull requests that update a dependency label Apr 11, 2024
@stefanprodan
Copy link
Member Author

stefanprodan commented Apr 11, 2024

Cosign forces the upgrade to cloud.google.com/go/storage v1.39.1 and this breaks the GCP Bucket tests, VisitObjects no longer works...

Fixed in: 6a2b26f

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Member

@souleb souleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanprodan stefanprodan merged commit 247cd7f into main Apr 11, 2024
10 checks passed
@stefanprodan stefanprodan deleted the cosign-v2.2.4 branch April 11, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants