Implement S3 bucket source #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Sep 18, 2020
| } | ||
|
|
||
| // download bucket content | ||
| for object := range s3Client.ListObjects(ctxTimeout, bucket.Spec.BucketName, minio.ListObjectsOptions{Recursive: true}) { |
There was a problem hiding this comment.
I think the ignores should already be taken into account here, as otherwise the revision will differ on any added file and/or change, while we want to ignore those.
There was a problem hiding this comment.
Discussed this a bit further: in a future iteration we would like to switch to an approach where the .sourceignore file is looked up first in the bucket, and combined with the .spec.ignore if it exists.
We can then use the merged ignore patterns to efficiently download the files we want to include whilst calculating the revision checksum at the same time, as done in https://github.com/fluxcd/source-controller/blob/v0.0.16/controllers/storage.go#L178-L211
hiddeco
approved these changes
Sep 18, 2020
stefanprodan
force-pushed
the
s3-bucket-controller
branch
3 times, most recently
from
d5c9794
to
6f8c381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Buckettype to APIBucketCRD and RBACBucketReconcilerusing minio go clientFix: #145
Proposal: fluxcd/flux2#242