Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitRepo: Remove provider default value from API #1626

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

darkowlzz
Copy link
Contributor

For backwards compatibility, remove the default value for GitRepository provider. An empty provider value will still be considered as the default generic provider.

For backwards compatibility, remove the default value for GitRepository
provider. An empty provider value will still be considered as the
default provider.

Signed-off-by: Sunny <github@darkowlzz.space>
@darkowlzz darkowlzz added area/git Git related issues and pull requests area/api API related issues and pull requests backport:release/v1.4.x To be backported to release/v1.4.x labels Sep 26, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @darkowlzz

@darkowlzz darkowlzz merged commit 8baf451 into main Sep 26, 2024
12 checks passed
@darkowlzz darkowlzz deleted the git-no-provider-default branch September 26, 2024 15:42
@fluxcdbot
Copy link
Member

Successfully created backport PR for release/v1.4.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API related issues and pull requests area/git Git related issues and pull requests backport:release/v1.4.x To be backported to release/v1.4.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants