git: refactor authentication, checkout and verification #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
git-auth-opts
branch
10 times, most recently
from
f7d7c9a
to
e5a548f
Compare
hiddeco
changed the title
hiddeco
force-pushed
the
git-auth-opts
branch
from
e5a548f
to
bcf83cb
Compare
hiddeco
added
area/git
hiddeco
force-pushed
the
git-auth-opts
branch
2 times, most recently
from
a3bff1c
to
d9a8004
Compare
hiddeco
force-pushed
the
git-auth-opts
branch
from
d9a8004
to
1f962d3
Compare
stefanprodan
approved these changes
Oct 24, 2021
| if short := strings.SplitAfterN(c.Reference, "/", 3); len(short) == 3 { | ||
| return fmt.Sprintf("%s/%s", short[2], c.Hash) | ||
| } | ||
| return fmt.Sprintf("HEAD/%s", c.Hash) |
There was a problem hiding this comment.
I think we need to document the revision format in docs/docs/spec/v1beta1/common.md for each source type and give some examples for Git.
darkowlzz
reviewed
Oct 24, 2021
darkowlzz
reviewed
Oct 24, 2021
darkowlzz
reviewed
Oct 24, 2021
hiddeco
force-pushed
the
git-auth-opts
branch
from
6b88b91
to
01aaba5
Compare
hiddeco
force-pushed
the
git-auth-opts
branch
3 times, most recently
from
35fcb23
to
3290736
Compare
This commit moves the previous `AuthStrategy` wiring to a more generic `AuthOptions`, breaking free from implementation specific details in the `git` package. Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
This commit refactors the previous `Commit` interface into a standardised `Commit` struct. This object contains sufficient information for referencing, observating and (PGP) verification. - `libgit2` commit checkout does now return `HEAD/<SHA1>` as the branch is not taken into account. - `git2go` objects are now properly `Free`d everywhere - `Verify` logic is tested. Signed-off-by: Hidde Beydals <hello@hidde.co>
This commit changes the `gogit` behavior for commit checkouts, now allowing one to reference to just a commit while omitting any branch reference. Doing this creates an Artifact with a `HEAD/<commit>` revision. If both a `branch` and `commit` are defined, the commit is expected to exist within the branch. This results in a more efficient clone of just the target branch, and also makes this change backwards compatible. Fixes #407 Fixes #315 Signed-off-by: Hidde Beydals <hello@hidde.co>
Main requirement for this is the image-automation-controller depending on being able to get a working auth configuration. Once the package is moved, we should add push logic to it, so that the controller is able to use that instead. Signed-off-by: Hidde Beydals <hello@hidde.co>
Adds more test cases for Validate() and an error for unknown transport. Signed-off-by: Sunny <darkowlzz@protonmail.com>
Adds tests for git.CheckoutStrategy to check if both the git implementations work with all the authentication methods. Signed-off-by: Sunny <darkowlzz@protonmail.com>
As we properly nest errors. Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
This changes the logic of `credentialsCallback` so that it takes the `allowedTypes` passed on by `git2go` into account. Reason for this change is because this prepares it to work with `v33`, but also because it can provide better guidance when `libgit2` has been compiled with a different configuration, which e.g. doesn't allow for "in-memory SSH keys". Because `AuthOptions#Identity` now gets validated by the callback and go-git does its own validaiton, the check has been removed from `Validate` (and now does a simple check if the fields are set). Signed-off-by: Hidde Beydals <hello@hidde.co>
Adds tests for git.CheckoutStrategy to check if both the git implementations follow the same SemVer tag selection rules. Signed-off-by: Sunny <darkowlzz@protonmail.com>
For ssh, Host field is required in AuthOptions. Signed-off-by: Sunny <darkowlzz@protonmail.com>
New gittestserver fixes the issue with custom branch in an initialized repo. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
git-auth-opts
branch
from
b7ac89c
to
0110664
Compare
Update GitRepositoryReconciler to use a nil authOpts unless it's configured. Signed-off-by: Sunny <darkowlzz@protonmail.com>
Signed-off-by: Hidde Beydals <hello@hidde.co>
darkowlzz
force-pushed
the
git-auth-opts
branch
from
054bb19
to
d0ca107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
gitpackage, so that the interface and generics no longer depend on implementation specifics. Commit metadata, (PGP) commit verification, and authentication options have been standardized into various structs and methods.User-facing Changes
Commit reference without branch
In the previous iteration it was not possible to define a Git commit reference without defining a branch. This limitation has been removed. However, using a branch if the information is available is beneficial for the
go-gitGit implementation, as this allows for a shallow clone. Forlibgit2, the branch is no longer taken into account.If just a Git commit reference is defined, the Artifact revision becomes
HEAD/<commit>Fixes #407
Fixes #315