Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC 0002] Flux OCI support for Helm #690

Merged
merged 7 commits into from
May 19, 2022
Merged

[RFC 0002] Flux OCI support for Helm #690

merged 7 commits into from
May 19, 2022

Commits on May 17, 2022

  1. wip: OCI Helm support 

    Signed-off-by: Max Jonas Werner <mail@makk.es>
    @souleb
    Max Jonas Werner authored and souleb committed May 17, 2022
    Configuration menu
    Copy the full SHA
    4903617 View commit details
    Browse the repository at this point in the history

  2. Add registryTestServer in the test suite and OCI HelmRepository test 

    case

Signed-off-by: Soule BA <soule@weave.works>
    @souleb
    souleb committed May 17, 2022
    Configuration menu
    Copy the full SHA
    5b01a92 View commit details
    Browse the repository at this point in the history

  3. fix event filters for HelmRepository reconcilers 

    We need to filter all events, not just update.

Signed-off-by: Max Jonas Werner <mail@makk.es>
    @souleb
    Max Jonas Werner authored and souleb committed May 17, 2022
    Configuration menu
    Copy the full SHA
    b3cf1e3 View commit details
    Browse the repository at this point in the history

  4. Add a new OCI chart repository type that manage tags and charts from … 

    …an OCI registry.

Adapat RemoteBuilder to accept both repository types

Signed-off-by: Soule BA <soule@weave.works>
    @souleb
    souleb committed May 17, 2022
    Configuration menu
    Copy the full SHA
    5cc7f20 View commit details
    Browse the repository at this point in the history

  5. remove debug statements 

    Signed-off-by: Max Jonas Werner <mail@makk.es>
    @souleb
    Max Jonas Werner authored and souleb committed May 17, 2022
    Configuration menu
    Copy the full SHA
    d31337b View commit details
    Browse the repository at this point in the history

  6. For backwards-compatibility, an empty .spec.type field now leads to 

    the HelmRepository being treated as a plain old HTTP Helm repository.

discard output from OCI registry client

The client has no way to set a verbosity level and spamming the
controller logs with "Login succeeded" every time the object is
reconciled doesn't help much.

Signed-off-by: Max Jonas Werner <mail@makk.es>
    @souleb
    Max Jonas Werner authored and souleb committed May 17, 2022
    Configuration menu
    Copy the full SHA
    cf408f7 View commit details
    Browse the repository at this point in the history

  7. Add OCI Helm support 

    If implemented:

- users will be able to declare OCI HelmRepository by using
the .Spec.Type field of the HelmRepository API. Contrary to the HTTP/S HelmRepository no index.yaml is reconciled from source, instead a simple url and credentials validation is performed.

- users will be able to declare the new OCI HelmRepository type as source using the .Spec.SourceRef field of the HelmChart API. This will result in reconciling a chart from an OCI repository.

Signed-off-by: Soule BA <soule@weave.works>
    @souleb
    souleb committed May 17, 2022
    Configuration menu
    Copy the full SHA
    482ec50 View commit details
    Browse the repository at this point in the history