Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement Cosign verification for HelmCharts #925

Merged
merged 6 commits into from
Oct 21, 2022
Merged

implement Cosign verification for HelmCharts #925

merged 6 commits into from
Oct 21, 2022

Commits on Oct 21, 2022

  1. Refactor to use authn for authentication as OCIrepository does 

    If implemented the oras registry loginOption will only be used internaly
with the specific ChartRepo struct.

This will permit reusing more easily feature developped with
googlecontainerregistry authn.

Signed-off-by: Soule BA <soule@weave.works>
    @souleb
    souleb committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    bb83270 View commit details
    Browse the repository at this point in the history

  2. Remove test case on aws 

    This remove test case for contextual login on
oci://123456789000.dkr.ecr.us-east-2.amazonaws.com.

This is not longer a wrong url since fluxcd/pkg@f7c66eb
and we no longer error on nil auth.

Signed-off-by: Soule BA <soule@weave.works>
    @souleb
    souleb committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    55dd799 View commit details
    Browse the repository at this point in the history

  3. implement Cosign verification for HelmCharts 

    If implemented, users will be able to enable chart verification for OCI
based helm charts.

Signed-off-by: Soule BA <soule@weave.works>
    @souleb
    souleb committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    0e97547 View commit details
    Browse the repository at this point in the history

  4. adding verfication section to HelmChart api doc 

    Signed-off-by: Soule BA <soule@weave.works>
    @souleb
    souleb committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    5355fb3 View commit details
    Browse the repository at this point in the history

  5. addressing review comments 

    Signed-off-by: Soule BA <soule@weave.works>
    @souleb
    souleb committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    25673ac View commit details
    Browse the repository at this point in the history

  6. Fix verification condition 

    Delete a failed verification condition at the beginning of the source
reconciliation and set `SourceVerifiedCondition` to false approprietly.

Set the `BuildOptions.Verify` to true as long as Verify is enabled in the
API fields.

Signed-off-by: Soule BA <soule@weave.works>
    @souleb
    souleb committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    06a5559 View commit details
    Browse the repository at this point in the history