Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minio: use container image for tests #981

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Dec 14, 2022

This drops the usage of play.min.io in favor of running a local container image for tests. Which is a better practice, and resolves test flakiness due to the endpoint being unavailable once in awhile.

@hiddeco hiddeco added area/ci CI related issues and pull requests area/bucket Bucket related issues and pull requests labels Dec 14, 2022
This drops the usage of `play.min.io` in favor of running a local
container image for tests. Which is a better practice, and resolves
test flakiness due to the endpoint being unavailable once in awhile.

Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco force-pushed the test-minio-container-img branch 4 times, most recently from 0469348 to cef8a78 Compare December 14, 2022 14:11
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco! 🙇

@hiddeco hiddeco merged commit 571ed0c into main Dec 14, 2022
@hiddeco hiddeco deleted the test-minio-container-img branch December 14, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bucket Bucket related issues and pull requests area/ci CI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants