-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Metrics, Logs and Events docs #1631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
darkowlzz
commented
Aug 22, 2023
- Add new metrics, logs and events docs.
- Update custom metrics docs based on the new example configuration.
- New path to KSM config. - Updated example config to include the suspend metrics label. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
more-monitoring-docs
branch
from
August 22, 2023 21:21
13041b5
to
9eec6a9
Compare
darkowlzz
commented
Aug 22, 2023
darkowlzz
force-pushed
the
more-monitoring-docs
branch
2 times, most recently
from
August 23, 2023 14:34
3c731e0
to
03afcd3
Compare
Signed-off-by: Sunny <darkowlzz@protonmail.com>
Signed-off-by: Sunny <darkowlzz@protonmail.com>
Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
more-monitoring-docs
branch
from
August 23, 2023 14:39
03afcd3
to
f4df785
Compare
stefanprodan
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @darkowlzz 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.