Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 #18

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Add PHP 8.4 #18

merged 4 commits into from
Dec 9, 2024

Conversation

heddn
Copy link
Contributor

@heddn heddn commented Dec 6, 2024

No description provided.

@heddn heddn mentioned this pull request Dec 6, 2024
@fideloper
Copy link
Contributor

Hey there! Thanks - can you please also add a new file here? https://github.com/fly-apps/laravel-docker/tree/main/src/php/packages

@heddn
Copy link
Contributor Author

heddn commented Dec 7, 2024

Hey there! Thanks - can you please also add a new file here? https://github.com/fly-apps/laravel-docker/tree/main/src/php/packages

Done

@fideloper
Copy link
Contributor

Thanks again!

Sorry to be annoying (one more request). I just updated branch main with a new github action workflow to run some builds against PR's so we can be sure it works.

Would you mind:

  1. updating your PR from main (it adds a new workflow file) - so it'll run a test build
  2. Updating the readme to include mention of php8.4

I appreciate it!

@fideloper
Copy link
Contributor

Looks like php8.4-swoole doesn't exist yet, perhaps we just leave it out for now.

@fideloper
Copy link
Contributor

That passed, sweet!

@fideloper fideloper merged commit abe1278 into fly-apps:main Dec 9, 2024
1 check passed
@fideloper
Copy link
Contributor

Thanks for your help there, let's get this out and see how it does.

@heddn heddn deleted the php84 branch December 9, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants