fix(fms): regression of approach ident on ND

[BravoMike99]

Fixes #[issue_no]

Summary of Changes

Fixes uncaught regression introduced in #8782 where approach ident would only be displayed when the actual approach procedure was being flown.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):
bruno_pt99

Testing instructions

A32NX or A380X:
Insert a destination airport & approach of your choice as long as it is not a runway only approach (visual).
Verify that the approach identifier shows on top of the ND when in cruise and distance to destination is less than 250NM or, once out of the cruise phase. This can be done by checking the progress page and looking at the green text at the top of the page ("CRZ"-> Cruise, "DES" -> Descent, "APPR"-> Approach, "GA"-> Go Around) on the A32NX and via the PERF page on the A380X.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, find and click on the PR Build tab
4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

[tracernz]

Needs a changelog.

[luckol3]

Quality Assurance Tester/Trainee Report

Discord Username : luckol3
Object of testing : #9158
Aircraft : A32NX
Tier of Testing : 1
Date : 28/10/2024
Testing Process:

1. Loaded VMMC-VHHH Flight
2. ILS 07R Does not show during descent/cruise/g.a
3. Only shows when established on LOC

Testing Results:
Approach identifier only shows when established on LOC and then thereafter

Testing Results:
Failed

Negatives:
Approach identifier does not show on the ND

Notes:
Using default nav data due to clean community folder.
Report approved to be posted by alepouna

Media:

[BravoMike99]

Quality Assurance Tester/Trainee Report

Discord Username : luckol3 Object of testing : #9158 Aircraft : A32NX Tier of Testing : 1 Date : 28/10/2024 Testing Process:

1. Loaded VMMC-VHHH Flight
2. ILS 07R Does not show during descent/cruise/g.a
3. Only shows when established on LOC

Testing Results: Approach identifier only shows when established on LOC and then thereafter

Testing Results: Failed

Negatives: Approach identifier does not show on the ND

Notes: Using default nav data due to clean community folder. Report approved to be posted by alepouna

Media:

It is working for me, can you give it a try again and observe the FMS phases in the progress page? The FMS needs to be in the "CRZ", "DES", "APPR" or "GA" phase for the identifier to appear. In the cruise case, distance to destination needs to be less than 250NM. I've updated the testing instructions accordingly
Cruise Phase:

Descent Phase:

[luckol3]

I have tried again. Still same results

CRZ

DES

APPR

GA

[BravoMike99]

I have tried again. Still same results

CRZ

DES

APPR

GA

That is strange, are you sure you are using the right version? (You can also open the fmgc.js file located at flybywire-aircraft-a320-neo\html_ui\JS\fbw-a32nx\fmgc in line 140176 and check that it says the following const runway = this.flightPlanService.active.destinationRunway; of the package which you are loading into the simulator. If it doesn't, chances are you are not using the correct build )

[luckol3]

2024-10-29.17-07-04.mp4

This is what 140176 shows, this is the latest version downloaded a few minutes ago.

[frenchairbuspilot]

QA Trainee Pilot Report

Discord : jp320
Object of testing: #9158
Tier of Testing : 1
Date : 31/10/2024

Testing Process:
tested 3 flights CDG-BRU LGW-BRU and LFRS EBBR, flight phases never switched to CRZ phase even though ALTZ CRZ was shown on FMA, trying to play with climb and descents but not succes.

Negatives:
CRZ phase never activated , CLB stayed displayed on PROG page

Testing Results:
Not Passed

Media:

[BravoMike99]

QA Trainee Pilot Report

Discord : jp320 Object of testing: #9158 Tier of Testing : 1 Date : 31/10/2024

Testing Process: tested 3 flights CDG-BRU LGW-BRU and LFRS EBBR, flight phases never switched to CRZ phase even though ALTZ CRZ was shown on FMA, trying to play with climb and descents but not succes.

Negatives: CRZ phase never activated , CLB stayed displayed on PROG page

Testing Results: Not Passed

Media:

I didn't change anything in regards to the flight phase logic so this is probably something unrelated to this PR :( . Can you replicate it on master? Might be worth logging an issue for

[frenchairbuspilot]

I didn't change anything in regards to the flight phase logic so this is probably something unrelated to this PR :( . Can you replicate it on master? Might be worth logging an issue for

I tried with the latest DEV version this morning, First flight from LFRS to EBBR FL220, all went ok as soon as ALT CRZ was shown on the FMA the prog page switched to CRZ phase. no APPR indication on ND at 250nm.

Second try, same route, with an intial cruise lvl at FL130. as soon as i reached alt crz on FMA, PROG page remained on CLB phase. even when i step climbed intially to FL 220, the auto change in crz alt on the prog was done, when reaching that altitude, prog page stayed in clb again... Then I went up to FL350, the PROG CRZ ALT stayed at FL220, I had to manually insert FL350 and when reaching that altitude and ALT CRZ on the FMA, the prog page was still in CLB phase...

I don't really know why it does this

[BravoMike99]

I didn't change anything in regards to the flight phase logic so this is probably something unrelated to this PR :( . Can you replicate it on master? Might be worth logging an issue for

I tried with the latest DEV version this morning, First flight from LFRS to EBBR FL220, all went ok as soon as ALT CRZ was shown on the FMA the prog page switched to CRZ phase. no APPR indication on ND at 250nm.

Second try, same route, with an intial cruise lvl at FL130. as soon as i reached alt crz on FMA, PROG page remained on CLB phase. even when i step climbed intially to FL 220, the auto change in crz alt on the prog was done, when reaching that altitude, prog page stayed in clb again... Then I went up to FL350, the PROG CRZ ALT stayed at FL220, I had to manually insert FL350 and when reaching that altitude and ALT CRZ on the FMA, the prog page was still in CLB phase...

I don't really know why it does this

Yes the approach ident on the ND is broken on master so that's fine. So it seems there's indeed something else going on with the FMS phases :/