Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/fms): FMC reset through overhead reset panel #9685

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Dec 29, 2024

Summary of Changes

Enable resetting FMCs through overhead reset panel. Lays ground work for future system resets.

  • Add XML templates for overhead reset panel buttons for FMCs
  • Add logic for FMS re-initialization when pulling C/Bs or rather reset P/Bs
  • Display "FMS PAGE NOT AVAIL" and "MAP NOT AVAIL" when appropriate

Screenshots (if necessary)

image

Disclaimer: Even when the ND shows "MAP NOT AVAIL", the route is still shown. Either it's the new BACKUP TRAJ feature, or I simply didn't refactor the ND yet (out of scope for this PR, needs larger flight guidance/AFS CP adaptions likely):
image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Set up FMS using SOP
  2. Pull FMC-A, FMC-B and FMC-C reset push buttons (on overhead panel), FMS should be reset as soon as all three buttons are pulled out - but not earlier

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Dec 29, 2024
Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked the XML.


<ModelBehaviors>
<Template Name="FBW_Airbus_RESET_PANEL_BUTTON">
<DefaultTemplateParameters>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please user <Parameters />. This legacy tag is deprecated and limited (that's why "subtemplates" used to be needed).

</DefaultTemplateParameters>

<UseTemplate Name="FBW_Push_Toggle">
<TOGGLE_SIMVAR>L:A32NX_RESET_PANEL_#COMPONENT#</TOGGLE_SIMVAR>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think component is a bit confusing as components are a part of the XML behaviours. NAME or something like that would be less confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA A380 Only QA only for A380 required
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

2 participants