Update lockfile with preferences #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is a fix for flyingcircusio/batou#145. |
ctheune
approved these changes
Jul 16, 2021
| if not preferences: | ||
| # We have no preferences defined, use the current python. | ||
| print("Update lockfile with with {}.".format(current_python)) | ||
| print("If you want to use a different version, set it as via") |
There was a problem hiding this comment.
Can we improve the wording a bit? I'd prefer if we make this a subtle warning: if you end up using different python versions on the controller and the deployment targets, lockfile-versions may not be sufficiently compatible and end up with missing dependencies.
There was a problem hiding this comment.
Forget it, I can live with the wording as is, I'd rather start using it to see whether this is helpful in day-to-day work.
|
I'm happy so far, please rebase so that we can see Github Actions approving this, too. |
Raise an error, if this python is not found. If nothing is configured, report the Python used and give a hint on configuration.
|
Rebased to master. |
|
@ctheune CI is green, so feel free to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be reviewed after #27 is merged.
Should then be applied to batou.