Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail if an attribute is set both in environment and via secrets. #190

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Fail if an attribute is set both in environment and via secrets. #190

merged 2 commits into from
Jun 25, 2021

Conversation

icemac
Copy link
Contributor

@icemac icemac commented Jun 18, 2021

Fixes #28.

ctheune
ctheune requested changes Jun 25, 2021
View reviewed changes
CHANGES.md Show resolved Hide resolved
@ctheune
Copy link
Member

ctheune commented Jun 25, 2021

I guess you need to rebase ...

@sallner
Copy link
Contributor

sallner commented Jun 25, 2021

Rebase applied.

@ctheune
Copy link
Member

ctheune commented Jun 25, 2021

Thanks!

@sallner
Copy link
Contributor

sallner commented Jun 25, 2021

Is there anything that has to be done before a merge?

@ctheune
Copy link
Member

ctheune commented Jun 25, 2021

No. I just forgot to click the second approval button ... -_-

@ctheune ctheune merged commit e422f6c into flyingcircusio:master Jun 25, 2021
@icemac icemac deleted the fix-28/duplicate-attribs branch June 28, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sallner sallner sallner left review comments

@ctheune ctheune ctheune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn if value is overriden both in secrets and the environment
3 participants
@icemac @ctheune @sallner