Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#272 error collection #320

Merged
merged 6 commits into from
Sep 19, 2022
Merged

#272 error collection #320

merged 6 commits into from
Sep 19, 2022

Conversation

elikoga
Copy link
Member

@elikoga elikoga commented Aug 26, 2022

@elikoga elikoga requested a review from ctheune as a code owner August 26, 2022 11:19
@elikoga elikoga force-pushed the 272-error-collection branch from ce800a7 to ac2e4d0 Compare September 8, 2022 13:28
@elikoga elikoga changed the title WIP: #272 error collection #272 error collection Sep 14, 2022
Copy link
Member

@ctheune ctheune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot. A few minor change requested annotated. And then please squash. :)

README.md Show resolved Hide resolved
src/batou/__init__.py Outdated Show resolved Hide resolved
src/batou/__init__.py Outdated Show resolved Hide resolved
src/batou/__init__.py Outdated Show resolved Hide resolved
src/batou/__init__.py Show resolved Hide resolved
src/batou/deploy.py Outdated Show resolved Hide resolved
src/batou/environment.py Outdated Show resolved Hide resolved
src/batou/remote_core.py Outdated Show resolved Hide resolved
src/batou/tests/test_dependencies.py Show resolved Hide resolved
src/batou/tests/test_endtoend.py Outdated Show resolved Hide resolved
@elikoga elikoga force-pushed the 272-error-collection branch 4 times, most recently from c04200a to 6475dad Compare September 19, 2022 08:26
pickle errors

w

bp

w

remove args from report

remove bp

replace map lambda with pythonic list compr

add rpitn

w

w

wip

wip

from_context

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

pre-commit

pass more data !

send other exceptions like before

add require_update

merge reports by affected hosts

output refinement

generator' object is not subscriptable

remove unneccessary set conversion

UnusedResources is created with a dict of list, not dict

what

wip

???

wip

adjust ConversionError error message

remove colons from tabular output

tabular output right aling 10->15

remove some affected hostname outputs

adjust error messages somewhat

remove unused accidental import

remove unused eq_reportable_exception

remove serialization prototype

sort errors

remove `errors =` from deploy.py

Docstring in the middle of nowhere

commanD

hostname comment can be removed

into a list of (reporting, ...) tuples

clarify continue comment

pickle error list directly

remove debug out
tests are broken for UnusedResources

fix some tests

fix UnusedResources Test

remove comments

uncomment test

add test output

remove debug out

fix test_endtoend

fix test_remote_core

remove debug write

tests

add test version ellipses

align test ellipsis with others

test output reordering?

fix test output order?

restore accidenntally removed tests

put gpg output into ellipsis

fix gpg ellipsis test

fix test

fix test

fix tests
@elikoga elikoga force-pushed the 272-error-collection branch from 6475dad to 2f653d1 Compare September 19, 2022 08:37
@ctheune ctheune merged commit 2183be7 into main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants