-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#272 error collection #320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elikoga
force-pushed
the
272-error-collection
branch
from
September 8, 2022 13:28
ce800a7
to
ac2e4d0
Compare
ctheune
requested changes
Sep 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot. A few minor change requested annotated. And then please squash. :)
elikoga
force-pushed
the
272-error-collection
branch
4 times, most recently
from
September 19, 2022 08:26
c04200a
to
6475dad
Compare
pickle errors w bp w remove args from report remove bp replace map lambda with pythonic list compr add rpitn w w wip wip from_context wip wip wip wip wip wip wip wip wip wip wip wip wip wip wip wip wip wip wip wip pre-commit pass more data ! send other exceptions like before add require_update merge reports by affected hosts output refinement generator' object is not subscriptable remove unneccessary set conversion UnusedResources is created with a dict of list, not dict what wip ??? wip adjust ConversionError error message remove colons from tabular output tabular output right aling 10->15 remove some affected hostname outputs adjust error messages somewhat remove unused accidental import remove unused eq_reportable_exception remove serialization prototype sort errors remove `errors =` from deploy.py Docstring in the middle of nowhere commanD hostname comment can be removed into a list of (reporting, ...) tuples clarify continue comment pickle error list directly remove debug out
tests are broken for UnusedResources fix some tests fix UnusedResources Test remove comments uncomment test add test output remove debug out fix test_endtoend fix test_remote_core remove debug write tests add test version ellipses align test ellipsis with others test output reordering? fix test output order? restore accidenntally removed tests put gpg output into ellipsis fix gpg ellipsis test fix test fix test fix tests
elikoga
force-pushed
the
272-error-collection
branch
from
September 19, 2022 08:37
6475dad
to
2f653d1
Compare
ctheune
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#272