Make ensure_path_nonexistent race condition aware #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctheune
requested changes
Dec 21, 2023
ctheune
reviewed
Jan 5, 2024
src/batou/lib/file.py
Outdated
| path_basename = os.path.basename(os.path.normpath(path)) | ||
|
|
||
| with tempfile.TemporaryDirectory(dir=parent_dir) as temp_dir: | ||
| os.rename(path, os.path.join(temp_dir, path_basename)) |
There was a problem hiding this comment.
This can fail because the whole idea of a race condition means someone else might be doing unexpected stuff, so failing renames should be ignored if the path to delete is gone in any case.
There was a problem hiding this comment.
This context manager is for deleting the Temporary Directory. No assumption that os.rename may fail, but the happy path thankfully includes a deletion of the tmpdir
I can split it up if this is misleading
There was a problem hiding this comment.
The rename needs to be wrapped in a try/except. Ignore for FileNotFound, re-raise in other cases.
ctheune
reviewed
Jan 24, 2024
ctheune
reviewed
Jan 24, 2024
ctheune
reviewed
Jan 24, 2024
ctheune
approved these changes
Jan 29, 2024
ctheune
added a commit
that referenced
this pull request
Jan 30, 2024
…nt-race-condition-aware Make ensure_path_nonexistent race condition aware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is susceptible to the same race conditions as the implementation from before, however it is able to notice the race condition and fail accordingly.
closes #275