Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning: If component has update() but no verify() #471

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

elikoga
Copy link
Member

@elikoga elikoga commented Sep 3, 2024

Implements #392

Currently rebased on top of #470

@elikoga elikoga force-pushed the warn-if-has-update-but-no-verify branch from 889d1c1 to de51763 Compare September 10, 2024 08:13
@elikoga elikoga force-pushed the warn-if-has-update-but-no-verify branch from de51763 to fb7e9cf Compare September 10, 2024 08:23
@elikoga elikoga marked this pull request as ready for review September 10, 2024 09:04
@elikoga elikoga requested a review from zagy as a code owner September 10, 2024 09:04
zagy
zagy previously approved these changes Sep 10, 2024
@elikoga elikoga dismissed zagy’s stale review September 10, 2024 09:47

The merge-base changed after approval.

zagy
zagy previously approved these changes Sep 10, 2024
@elikoga elikoga dismissed zagy’s stale review September 10, 2024 09:54

The merge-base changed after approval.

zagy
zagy previously approved these changes Oct 8, 2024
@elikoga elikoga dismissed zagy’s stale review October 8, 2024 09:41

The merge-base changed after approval.

@zagy zagy merged commit 09b5eec into main Oct 8, 2024
15 checks passed
@zagy zagy deleted the warn-if-has-update-but-no-verify branch October 8, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants