Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add update-nixpkgs tooling #1173

Closed
wants to merge 1 commit into from
Closed

ci: Add update-nixpkgs tooling #1173

wants to merge 1 commit into from

Conversation

leona-ya
Copy link
Member

@leona-ya leona-ya commented Nov 25, 2024 •
edited
Loading

@flyingcircusio/release-managers

PL-133100

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • Should work, should not interfere with current release branches in fc-nixos and nixpkgs
  • Security requirements tested? (EVIDENCE)
    • Tested in fc-nixos-testing
    • By design the scripts only automatically update integrations branches
    • The actual review/merge is done by a human and assisted by GHA

@leona-ya @Ma27
ci: Add update-nixpkgs tooling
0c758b8 
PL-133100

Co-Authored-By: Max Bosch <mb@flyingcircus.io>
ctheune
ctheune requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@ctheune ctheune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, there's a few annotations.

Moving most of the code to the release repo sounds like a good idea.

.github/workflows/update-nixpkgs.yaml
on:
workflow_dispatch: {}
schedule:
- cron: "5 8 * * *"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great if we already had the result in our Hydra in the morning, so maybe 3am?

.github/workflows/update-nixpkgs.yaml
- uses: actions/checkout@v4
- uses: cachix/install-nix-action@v21
with:
install_url: https://releases.nixos.org/nix/nix-2.18.9/install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newer nix breaks here, maybe comment and maybe hand over to max?

ci/update-nixpkgs.py
head=integration_branch,
title=f"Auto update nixpkgs {now}",
body=f"""\
View nixpkgs update branch: [{integration_branch}](https://github.com/{NIXPKGS_REPO}/tree/{integration_branch})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More more guidance how to deal with this PR, general workflow and edge cases (merge/rebase conflicts)

@leona-ya leona-ya closed this Dec 4, 2024
@leona-ya leona-ya mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctheune ctheune ctheune requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leona-ya @ctheune