Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move package-, version update scripts to flake apps #1187

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

leona-ya
Copy link
Member

@leona-ya leona-ya commented Dec 4, 2024

This is to support the update-nixpkgs workflow without a devenv shell.

@flyingcircusio/release-managers

Release process

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • works
  • Security requirements tested? (EVIDENCE)
    • tested locally with nix run .#{buildVersionsJson, buildPackageVersionsJson}

This is to support the update-nixpkgs workflow without a devenv shell.
@leona-ya leona-ya requested a review from ctheune December 4, 2024 15:43
@ctheune ctheune merged commit 171192a into fc-24.05-dev Dec 4, 2024
2 checks passed
@ctheune ctheune deleted the PL-133100-update-nixpkgs-flake branch December 4, 2024 16:28
PhilTaken pushed a commit that referenced this pull request Dec 9, 2024
…-flake

move package-, version update scripts to flake apps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants