Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lamp: named php pools #781

Merged
merged 1 commit into from
Sep 27, 2023
Merged

lamp: named php pools #781

merged 1 commit into from
Sep 27, 2023

Conversation

PhilTaken
Copy link
Member

@PhilTaken PhilTaken commented Sep 13, 2023

@flyingcircusio/release-managers

Add an attribute "name" to lamp vhosts. This extra attribute makes specific pools more recognizable, especially when the php and composer packages in conjunction with the pool's specific php ini are required for setting up docroots.

Release process

Impact:

Changelog:

  • Added an attribute "name" for vhosts in the flyingcircus lamp module. The default behavior remains identical.

Security implications

  • Security requirements defined? (WHERE)
    • must not change existing scripts, especially alerting rules
  • Security requirements tested? (EVIDENCE)
    • the default behavior is identical

@PhilTaken PhilTaken requested review from ctheune and dpausp September 13, 2023 13:20
@dpausp dpausp merged commit 9fbc8ce into fc-23.05-dev Sep 27, 2023
1 check passed
@dpausp dpausp deleted the phil/named-php-pools branch September 27, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants