Add function EventEmitter.removeListener, compatible react-native EventEmitter path #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyskywhy
reviewed
Aug 25, 2017
| * @param {Object} listener - Created by addListener | ||
| */ | ||
| removeListener(listener: Object) { | ||
| this._subscriber.removeSubscription(listener) |
There was a problem hiding this comment.
我看到 https://github.com/magicismight/react-native-root-siblings/blob/9cd2e112e5668173c9d98dc6dace6fc3b029274b/lib/AppRegistryInjection.js#L36 调用的是 emitter.removeListener('siblings.update', this._update); ，是两个参数的，而你此处是接收一个参数的。看起来 https://github.com/facebook/react-native/blob/405c573e0d41cdcb9f05b5a1b9a81a4ad9f97369/Libraries/EventEmitter/EventEmitter.js#L204 这个 removeListener(eventType: String, listener) 函数更合适参考。
flyskywhy
reviewed
Aug 25, 2017
| @@ -0,0 +1,2 @@ | |||
| var EventEmitter = require('../vendor/EventEmitter'); | |||
There was a problem hiding this comment.
然后要不参考一下 facebook/react-native@516bf7b ，将 vendor/emitter/ 变为 Libraries/EventEmitter/ ？当然目前这样 var EventEmitter = require('../vendor/EventEmitter'); 也不失为一种简洁的处理方式 😄
|
确实。之前的场景只是让它能基本工作，removeListener应该是没走到。 不过我这几天没有工作在这个环境，要晚些再看了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatible react-native-root-siblings (maybe other libraries).
At https://github.com/magicismight/react-native-root-siblings/blob/master/lib/AppRegistryInjection.js#L4, it depends path
'react-native/Libraries/EventEmitter/EventEmitter'.At https://github.com/magicismight/react-native-root-siblings/blob/master/lib/AppRegistryInjection.js#L36, it depends EventEmitter.removeListener.