modules pcf8574/5 always use pullups (#234)

* allow to not use pullups for PCF8574 module * allow to not use pullups for PCF8575 module
flyte · Jul 11, 2023 · 8a6d7e7 · 8a6d7e7
1 parent 9de3e74
commit 8a6d7e7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/mqtt_io/modules/gpio/pcf8574.py b/mqtt_io/modules/gpio/pcf8574.py
@@ -35,7 +35,7 @@ def setup_pin(
         pin_config: ConfigType,
         initial: Optional[str] = None,
     ) -> None:
-        if direction == PinDirection.INPUT and pullup is not None:
+        if direction == PinDirection.INPUT and self.pullup_map[pullup] is not None:
             self.io.port[pin] = self.pullup_map[pullup]
         initial = pin_config.get("initial")
         if initial is not None:

diff --git a/mqtt_io/modules/gpio/pcf8575.py b/mqtt_io/modules/gpio/pcf8575.py
@@ -35,7 +35,7 @@ def setup_pin(
         pin_config: ConfigType,
         initial: Optional[str] = None,
     ) -> None:
-        if direction == PinDirection.INPUT and pullup is not None:
+        if direction == PinDirection.INPUT and self.pullup_map[pullup] is not None:
             self.io.port[pin] = self.pullup_map[pullup]
         initial = pin_config.get("initial")
         if initial is not None: