Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ads1x15.py #329

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Update ads1x15.py #329

merged 4 commits into from
Jan 2, 2024

Conversation

maxthebuch
Copy link
Contributor

Avoids race condition when reading a channel

Avoids race condition when reading a channel
@skvsn
Copy link

skvsn commented Nov 16, 2023

I'm using ads1115 on my RPI4 and if I configure more that one channel - mqtt-io seems to crash after some time. When running with only one channel - everything works perfectly. So hopefully this will fix this problem. Another way of achieving this could be by setting max_workers=1 on this module's ThreadPoolExecutor object

Avoids race condition when reading a channel
Formatting with Lint
@maxthebuch maxthebuch closed this Nov 17, 2023
@maxthebuch maxthebuch reopened this Nov 17, 2023
Copy link
Contributor Author

@maxthebuch maxthebuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting with LINT

@skvsn
Copy link

skvsn commented Nov 18, 2023

I tested this version with all 4 channels enabled - it is running fine for more than day now and not crashing as before. Would be great if this fix could be included in the main branch of mqtt-io

@mschlenstedt
Copy link
Contributor

mschlenstedt commented Jan 1, 2024

@flyte Happy New Year ;-)

Any time to include this PR and make a new version? Would be great, since this is really an important Bugfix when using an ads1x15

@BenjiU BenjiU merged commit 390cc52 into flyte:develop Jan 2, 2024
Bluscream added a commit to Bluscream/mqtt-io that referenced this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants