lint

Signed-off-by: Kevin Su <pingsutw@apache.org>
flyteorg · Sep 5, 2024 · a9d7bee · a9d7bee
1 parent 4d89c29
commit a9d7bee
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/flyteadmin/pkg/common/naming/execution_name_test.go b/flyteadmin/pkg/common/naming/execution_name_test.go
@@ -65,7 +65,7 @@ func TestGetExecutionName(t *testing.T) {
 	})
 
 	t.Run("deterministic name", func(t *testing.T) {
-		hashValue := identifier.HashScheduledTimeStamp(context.Background(), core.Identifier{
+		hashValue := identifier.HashScheduledTimeStamp(context.Background(), &core.Identifier{
 			Project: "Project",
 			Domain:  "Domain",
 			Name:    "Name",

diff --git a/flyteadmin/scheduler/executor/executor_impl.go b/flyteadmin/scheduler/executor/executor_impl.go
@@ -54,7 +54,7 @@ func (w *executor) Execute(ctx context.Context, scheduledTime time.Time, s model
 	}
 
 	// Making the identifier deterministic using the hash of the identifier and scheduled time
-	hashValue := identifier.HashScheduledTimeStamp(ctx, core.Identifier{
+	hashValue := identifier.HashScheduledTimeStamp(ctx, &core.Identifier{
 		Project: s.Project,
 		Domain:  s.Domain,
 		Name:    s.Name,

diff --git a/flyteadmin/scheduler/identifier/identifier.go b/flyteadmin/scheduler/identifier/identifier.go
@@ -33,7 +33,7 @@ func GetScheduleName(ctx context.Context, s models.SchedulableEntity) string {
 }
 
 // GetExecutionIdentifier returns UUID using the hashed value of the schedule identifier and the scheduledTime
-func GetExecutionIdentifier(ctx context.Context, identifier core.Identifier, scheduledTime time.Time) (uuid.UUID, error) {
+func GetExecutionIdentifier(ctx context.Context, identifier *core.Identifier, scheduledTime time.Time) (uuid.UUID, error) {
 	hashValue := HashScheduledTimeStamp(ctx, identifier, scheduledTime)
 	b := make([]byte, 16)
 	binary.LittleEndian.PutUint64(b, hashValue)
@@ -56,7 +56,7 @@ func hashIdentifier(ctx context.Context, identifier *core.Identifier) uint64 {
 }
 
 // HashScheduledTimeStamp return the hash of the identifier and the scheduledTime
-func HashScheduledTimeStamp(ctx context.Context, identifier core.Identifier, scheduledTime time.Time) uint64 {
+func HashScheduledTimeStamp(ctx context.Context, identifier *core.Identifier, scheduledTime time.Time) uint64 {
 	h := fnv.New64()
 	_, err := h.Write([]byte(fmt.Sprintf(executionIDInputsFormat,
 		identifier.Project, identifier.Domain, identifier.Name, identifier.Version, scheduledTime.Unix())))