Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][Performance] Clear managed fields from FlyteWorkflow CRD #1714

Closed
2 tasks done
hamersaw opened this issue Oct 19, 2021 · 0 comments · Fixed by flyteorg/flytepropeller#344
Closed
2 tasks done
Assignees
Labels
enhancement New feature or request flytepropeller propeller Issues related to flyte propeller scale Scale, Reliability and Performance of the platform
Milestone

Comments

@hamersaw
Copy link
Contributor

Motivation: Why do you think this is important?

K8s tracked managed fields as a way to ensure some level of access control over resources. The FlyteWorkflow is one such resource. However, flyte ensures that each FlyteWorkflow is only managed by a single FlytePropeller instance. Therefore, managed fields are unnecessary.

In the general case this is not an issue, but in the case of large workflows (ie. many nodes), which may result from large fanout dynamic tasks among other phenomena, the managed fields can bloat CRDs by 100's of KB. Etcd read / write performance is often contingent on small key / value pairs and degradation over large values is a known issue.

Goal: What should the final outcome look like, ideally?

Managed fields should be cleared on all FlyteWorkflow CRDs.

Describe alternatives you've considered

Existing approach is to leave the managed fields.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@hamersaw hamersaw added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Oct 19, 2021
@kumare3 kumare3 added flytepropeller propeller Issues related to flyte propeller scale Scale, Reliability and Performance of the platform and removed untriaged This issues has not yet been looked at by the Maintainers labels Oct 19, 2021
@kumare3 kumare3 added this to the 0.18.1 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flytepropeller propeller Issues related to flyte propeller scale Scale, Reliability and Performance of the platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants