This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Clear managed fields on FlyteWorkflow CRD #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd managed fields Signed-off-by: Daniel Rammer <daniel@union.ai>
kumare3
reviewed
Oct 20, 2021
| // FlyteWorkflow CRDs are only managed by a single FlytePropeller instance and therefore the managed fields paradigm | ||
| // does not add useful functionality. Clearing them reduces CRD size, improving etcd I/O performance. | ||
| if len(workflow.ObjectMeta.ManagedFields) > 0 { | ||
| workflow.ObjectMeta.ManagedFields = workflow.ObjectMeta.ManagedFields[:1] |
There was a problem hiding this comment.
can we not just set it to an empty array?
There was a problem hiding this comment.
"Note that setting the managedFields to an empty list will not reset the field. This is on purpose, so managedFields never get stripped by clients not aware of the field." (https://kubernetes.io/docs/reference/using-api/server-side-apply/#clearing-managedfields)
We need to set it to a 1 element array with an empty ManagedField entry.
kumare3
approved these changes
Oct 20, 2021
2 tasks
9 tasks
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
…rd managed fields (flyteorg#344) Signed-off-by: Daniel Rammer <daniel@union.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
During each FlyteWorkflow CRD update we check for existing managed field entities and set the field to a list with a single empty instance. K8s server side apply uses this to clear managed fields. Managed fields are unused since Flyte ensures only a single FlytePropeller instance manages each FlyteWorkflow. Removing them reduces CRD size to improve etcd read / write performance.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#1714
Follow-up issue
NA