Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace other instances of rli #6014

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

eapolinario
Copy link
Contributor

Why are the changes needed?

Similar to #6008, this PR deletes the remaining instances of {rli}.

Note that in one case I replaced the rli with a code-block, since that's supposed to be a file. I'm not sure if that's the appropriate way of displaying these simple files.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario enabled auto-merge (squash) November 14, 2024 22:36
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.97%. Comparing base (f62c7b6) to head (e4a116f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6014   +/-   ##
=======================================
  Coverage   36.97%   36.97%           
=======================================
  Files        1312     1312           
  Lines      131516   131516           
=======================================
+ Hits        48623    48627    +4     
+ Misses      78666    78662    -4     
  Partials     4227     4227           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.07% <ø> (ø)
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.44% <ø> (+0.04%) ⬆️
unittests-flyteidl 7.05% <ø> (ø)
unittests-flyteplugins 53.80% <ø> (ø)
unittests-flytepropeller 43.10% <ø> (ø)
unittests-flytestdlib 55.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 75e5cca into master Nov 14, 2024
51 of 52 checks passed
@eapolinario eapolinario deleted the replace-other-uses-of-rli branch November 14, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants