Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Implement GetFlyteKitMetrics endpoint #575

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Yicheng-Lu-llll
Copy link
Member

@Yicheng-Lu-llll Yicheng-Lu-llll commented Jun 14, 2023

TL;DR

This is part of Flytekit Metrics Exploration.

This PR Implements GetFlyteKitMetrics endpoint(also highlighted in green):

  • Download flytekit spans for a particular node from remote storage.
  • Send flytekit spans to console.
image

Checks

/api/v1/metrics/node_executions/{id.execution_id.project}/{id.execution_id.domain}/{id.execution_id.name}/{id.node_id}
image

Flytekit Metrics Exploration includes:

Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
@welcome
Copy link

welcome bot commented Jun 14, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
@Yicheng-Lu-llll Yicheng-Lu-llll changed the title [WIP] Implement GetFlyteKitMetrics endpoint Implement GetFlyteKitMetrics endpoint Jun 14, 2023
@Yicheng-Lu-llll Yicheng-Lu-llll marked this pull request as ready for review June 14, 2023 18:58
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
return nil, err
}

blob, err := m.urlData.Get(ctx, nodeExecution.Closure.SpanUri)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: m.urlData.Get generates the signed URL. We may not need it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant