chore: dparent null in alt paths (#775)

Signed-off-by: Carina Ursu <carina@union.ai>
flyteorg · Jun 16, 2023 · 4783c39 · 4783c39
1 parent 3184646
commit 4783c39
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 12 deletions.
diff --git a/packages/console/package.json b/packages/console/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@flyteorg/console",
-  "version": "0.0.37",
+  "version": "0.0.38",
   "description": "Flyteconsole main app module",
   "main": "./dist/index.js",
   "module": "./lib/index.js",

diff --git a/packages/console/src/components/Executions/nodeExecutionQueries.ts b/packages/console/src/components/Executions/nodeExecutionQueries.ts
@@ -64,21 +64,25 @@ export function makeNodeExecutionAndTasksQuery(
   id: NodeExecutionIdentifier,
   queryClient: QueryClient,
   dynamicParentNodeId?: string,
-): QueryInput<WorkflowNodeExecution> {
+) {
   return {
     queryKey: [QueryType.NodeExecutionAndTasks, id],
     queryFn: async () => {
       // step 1: Fetch the Node execution
       const nodeExecutionPure = await getNodeExecution(id);
 
+      const dynamicParent = dynamicParentNodeId
+        ? await getNodeExecution({ ...id, nodeId: dynamicParentNodeId })
+        : null;
+
       // step 2: Fetch the task executions and attach them to the node execution
       const workflowNodeExecution = (await getTaskExecutions(
         queryClient,
         nodeExecutionPure,
       )) as WorkflowNodeExecution;
 
       if (!workflowNodeExecution) {
-        return {} as WorkflowNodeExecution;
+        return [{} as WorkflowNodeExecution];
       }
 
       workflowNodeExecution.scopedId = workflowNodeExecution?.id?.nodeId;
@@ -111,11 +115,22 @@ export function makeNodeExecutionAndTasksQuery(
         ),
       );
 
-      return {
-        ...workflowNodeExecution,
-        taskExecutions: tasksExecutionData,
-        nodeExecutionData,
-      } as WorkflowNodeExecution;
+      const final = [
+        {
+          ...workflowNodeExecution,
+          taskExecutions: tasksExecutionData,
+          nodeExecutionData,
+        } as WorkflowNodeExecution,
+      ];
+
+      if (dynamicParent) {
+        final.push({
+          ...(dynamicParent as WorkflowNodeExecution),
+          scopedId: dynamicParentNodeId,
+        });
+      }
+
+      return final;
     },
   };
 }

diff --git a/packages/console/src/components/common/utils.ts b/packages/console/src/components/common/utils.ts
@@ -49,7 +49,9 @@ export const checkForDynamicExecutions = (allExecutions, staticExecutions) => {
   const result = {};
   for (const parentId in parentsToFetch) {
     const execution = executionsByNodeId[parentId];
-    result[execution.scopedId] = execution;
+    if (execution) {
+      result[execution.scopedId] = execution;
+    }
   }
   return result;
 };
diff --git a/website/package.json b/website/package.json
@@ -37,7 +37,7 @@
   },
   "dependencies": {
     "@flyteorg/common": "^0.0.4",
-    "@flyteorg/console": "^0.0.37",
+    "@flyteorg/console": "^0.0.38",
     "long": "^4.0.0",
     "protobufjs": "~6.11.3",
     "react-ga4": "^1.4.1",

diff --git a/yarn.lock b/yarn.lock
@@ -2020,7 +2020,7 @@ __metadata:
   resolution: "@flyteconsole/client-app@workspace:website"
   dependencies:
     "@flyteorg/common": ^0.0.4
-    "@flyteorg/console": ^0.0.37
+    "@flyteorg/console": ^0.0.38
     "@types/long": ^3.0.32
     long: ^4.0.0
     protobufjs: ~6.11.3
@@ -2059,7 +2059,7 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@flyteorg/console@^0.0.37, @flyteorg/console@workspace:packages/console":
+"@flyteorg/console@^0.0.38, @flyteorg/console@workspace:packages/console":
   version: 0.0.0-use.local
   resolution: "@flyteorg/console@workspace:packages/console"
   dependencies: