fix: fix test for utils.test.ts #none

Signed-off-by: James <james@union.ai>
flyteorg · May 27, 2022 · 47e3d9c · 47e3d9c
1 parent d74a3ab
commit 47e3d9c
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/packages/zapp/console/src/components/Launch/LaunchForm/inputHelpers/test/testCases.ts b/packages/zapp/console/src/components/Launch/LaunchForm/inputHelpers/test/testCases.ts
@@ -111,7 +111,6 @@ export const supportedPrimitives: InputTypeDefinition[] = [
   inputTypes.integer,
   inputTypes.schema,
   inputTypes.struct,
-  inputTypes.map,
 ];
 
 export const unsupportedTypes: InputTypeDefinition[] = [

diff --git a/packages/zapp/console/src/components/Launch/LaunchForm/inputHelpers/test/utils.test.ts b/packages/zapp/console/src/components/Launch/LaunchForm/inputHelpers/test/utils.test.ts
@@ -1,6 +1,8 @@
 import {
   collectionInputTypeDefinition,
+  mapInputTypeDefinition,
   nestedCollectionInputTypeDefinition,
+  nestedMapInputTypeDefinition,
 } from '../../__mocks__/utils';
 import { InputTypeDefinition } from '../../types';
 import { typeIsSupported } from '../utils';
@@ -25,6 +27,16 @@ describe('Launch/inputHelpers/utils', () => {
         nestedCollectionInputTypeDefinition(typeDefinition),
         true,
       ]),
+      ...supportedPrimitives.map<TypeIsSupportedTestCase>((typeDefinition) => [
+        `supports 1-dimension map of type ${typeDefinition.type}`,
+        mapInputTypeDefinition(typeDefinition),
+        true,
+      ]),
+      ...supportedPrimitives.map<TypeIsSupportedTestCase>((typeDefinition) => [
+        `supports 2-dimension map of type: ${typeDefinition.type}`,
+        nestedMapInputTypeDefinition(typeDefinition),
+        true,
+      ]),
       ...unsupportedTypes.map<TypeIsSupportedTestCase>((typeDefinition) => [
         `does NOT support type ${typeDefinition.type}`,
         typeDefinition,
@@ -40,6 +52,16 @@ describe('Launch/inputHelpers/utils', () => {
         nestedCollectionInputTypeDefinition(typeDefinition),
         false,
       ]),
+      ...unsupportedTypes.map<TypeIsSupportedTestCase>((typeDefinition) => [
+        `does NOT support 1-dimension map of type ${typeDefinition.type}`,
+        mapInputTypeDefinition(typeDefinition),
+        false,
+      ]),
+      ...unsupportedTypes.map<TypeIsSupportedTestCase>((typeDefinition) => [
+        `does NOT support 2-dimension map of type: ${typeDefinition.type}`,
+        nestedMapInputTypeDefinition(typeDefinition),
+        false,
+      ]),
     ];
 
     cases.forEach(([description, value, expected]) =>

diff --git a/packages/zapp/console/src/components/Launch/LaunchForm/test/constants.ts b/packages/zapp/console/src/components/Launch/LaunchForm/test/constants.ts
@@ -7,6 +7,7 @@ export const datetimeInputName = 'simpleDatetime';
 export const integerInputName = 'simpleInteger';
 export const binaryInputName = 'simpleBinary';
 export const errorInputName = 'simpleError';
+export const mapInputName = 'simpleMap';
 
 export const iamRoleString = 'arn:aws:iam::12345678:role/defaultrole';
 export const k8sServiceAccountString = 'default-service-account';