fix: correctly coerce defaultValue when rendering LaunchPlan details (

#578) fix: correctly coerce defaultValue when rendering LaunchPlan details Signed-off-by: Rahul Mehta <rahul@theoremlp.com> Signed-off-by: Rahul Mehta <rahul@theoremlp.com>
flyteorg · Sep 6, 2022 · 7e3c6db · 7e3c6db
1 parent dc1c73f
commit 7e3c6db
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/packages/zapp/console/src/components/Entities/EntityInputs.tsx b/packages/zapp/console/src/components/Entities/EntityInputs.tsx
@@ -19,6 +19,13 @@ import * as React from 'react';
 import t from './strings';
 import { transformLiterals } from '../Literals/helpers';
 
+const coerceDefaultValue = (value: string | object | undefined): string | undefined => {
+  if (typeof value === 'object') {
+    return JSON.stringify(value);
+  }
+  return value;
+};
+
 const useStyles = makeStyles((theme: Theme) => ({
   header: {
     marginBottom: theme.spacing(1),
@@ -179,7 +186,7 @@ export const EntityInputs: React.FC<{
                       <TableCell align="center">
                         {required ? <CheckIcon fontSize="small" /> : ''}
                       </TableCell>
-                      <TableCell>{defaultValue || '-'}</TableCell>
+                      <TableCell>{coerceDefaultValue(defaultValue) || '-'}</TableCell>
                     </TableRow>
                   ))}
                 </TableBody>
@@ -214,7 +221,7 @@ export const EntityInputs: React.FC<{
                   {fixedInputs.map(({ name, defaultValue }) => (
                     <TableRow key={name}>
                       <TableCell>{name}</TableCell>
-                      <TableCell>{defaultValue || '-'}</TableCell>
+                      <TableCell>{coerceDefaultValue(defaultValue) || '-'}</TableCell>
                     </TableRow>
                   ))}
                 </TableBody>