feat: differentiate between cache disabled and cache put failure (#719)

fix: add icon for put failure Signed-off-by: James <james@union.ai>
flyteorg · Mar 10, 2023 · be0e533 · be0e533
1 parent ffb161c
commit be0e533
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/packages/console/src/components/Executions/CacheStatus.tsx b/packages/console/src/components/Executions/CacheStatus.tsx
@@ -3,6 +3,7 @@ import { makeStyles, Theme } from '@material-ui/core/styles';
 import CachedOutlined from '@material-ui/icons/CachedOutlined';
 import ErrorOutlined from '@material-ui/icons/ErrorOutlined';
 import InfoOutlined from '@material-ui/icons/InfoOutlined';
+import SmsFailedOutlinedIcon from '@material-ui/icons/SmsFailedOutlined';
 import classnames from 'classnames';
 import { assertNever } from 'common/utils';
 import { PublishedWithChangesOutlined } from 'components/common/PublishedWithChanges';
@@ -37,10 +38,14 @@ const NodeExecutionCacheStatusIcon: React.ComponentType<
   }
 > = React.forwardRef(({ status, ...props }, ref) => {
   switch (status) {
-    case CatalogCacheStatus.CACHE_DISABLED:
+    case CatalogCacheStatus.CACHE_DISABLED: {
+      return <InfoOutlined {...props} ref={ref} data-testid="cache-icon" />;
+    }
     case CatalogCacheStatus.CACHE_MISS:
     case CatalogCacheStatus.CACHE_SKIPPED: {
-      return <InfoOutlined {...props} ref={ref} data-testid="cache-icon" />;
+      return (
+        <SmsFailedOutlinedIcon {...props} ref={ref} data-testid="cache-icon" />
+      );
     }
     case CatalogCacheStatus.CACHE_HIT: {
       return <CachedOutlined {...props} ref={ref} data-testid="cache-icon" />;