Skip to content

Commit

Permalink
fix: upgrading node version to 18 (#703)
Browse files Browse the repository at this point in the history
Upgrading node version to 18

Signed-off-by: Jason Porter <jason@union.ai>
  • Loading branch information
jsonporter authored Mar 4, 2023
1 parent b15470b commit e5f9a8b
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v2
with:
node-version: 16
node-version: 18
- uses: bahmutov/npm-install@v1
- name: Run tests and generate coverage
run: make test_unit_codecov
Expand All @@ -46,7 +46,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 16
node-version: 18
- uses: bahmutov/npm-install@v1
- name: Run linter
run: make lint
Expand All @@ -66,15 +66,21 @@ jobs:
release:
name: Generate Release
if: ${{ (github.event_name != 'pull_request') && (needs.extract_branch.outputs.branch == 'master') }}
needs: [unit_tests_with_coverage, lint_project, build_docker_image, extract_branch]
needs:
[
unit_tests_with_coverage,
lint_project,
build_docker_image,
extract_branch,
]
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: 16
node-version: 18
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Release
Expand Down Expand Up @@ -113,7 +119,7 @@ jobs:
push_docker_image:
name: Build & Push FlyteConsole Image
if: ${{ needs.check_for_tag.outputs.currentTag != '' }}
needs: [ check_for_tag ]
needs: [check_for_tag]
uses: flyteorg/flytetools/.github/workflows/publish.yml@master
with:
before-build: |
Expand Down

0 comments on commit e5f9a8b

Please sign in to comment.