fix: break link between cache and context state

Signed-off-by: James <james@union.ai>
flyteorg · Mar 30, 2023 · f3339c9 · f3339c9
1 parent 0c5c96b
commit f3339c9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/console/src/components/Executions/contextProvider/NodeExecutionDetails/index.tsx b/packages/console/src/components/Executions/contextProvider/NodeExecutionDetails/index.tsx
@@ -96,12 +96,12 @@ export const NodeExecutionDetailsContextProvider = (props: ProviderProps) => {
         name,
         version,
       };
-      const workflow = await fetchWorkflow(queryClient, workflowId);
-      if (!workflow) {
+      const result = await fetchWorkflow(queryClient, workflowId);
+      if (!result) {
         resetState();
         return;
       }
-
+      const workflow = JSON.parse(JSON.stringify(result));
       const tree = createExecutionDetails(workflow);
       if (isCurrent) {
         setClosure(workflow.closure?.compiledWorkflow ?? null);

diff --git a/packages/console/src/components/Workflow/workflowQueries.ts b/packages/console/src/components/Workflow/workflowQueries.ts
@@ -23,6 +23,9 @@ export function makeWorkflowQuery(
 
       return workflow;
     },
+    // `Workflow` objects (individual versions) are immutable and safe to
+    // cache indefinitely once retrieved in full
+    staleTime: Infinity,
   };
 }