Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Merge devmain into master #patch #474

Merged
merged 26 commits into from
May 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
0f9516b
chore: move src to a new location
anrusina Apr 24, 2022
b984ef5
ci: allow branch to be built again
anrusina Apr 24, 2022
81c9b7a
chore: replace link to github repository to a proper one
anrusina Apr 25, 2022
cdaca10
ci: basic test and test-coverage setup
anrusina Apr 25, 2022
4f61e22
chore: add first plugin package
anrusina Apr 25, 2022
19ea691
chore: allow to start test from main directory
anrusina Apr 25, 2022
80cc04c
ci: update lowest mkdirp version (#423)
anrusina Apr 25, 2022
ff31591
chore: add build scripts for console app (#429)
ursucarina Apr 26, 2022
e53e585
fix: hide the legend (#435)
eugenejahn Apr 28, 2022
c612b3b
ci: move storybook related packages to top level (#434)
anrusina Apr 28, 2022
92987f5
fix: fix issue 386 (#437)
eugenejahn Apr 28, 2022
13fa646
ci: ensure unified tsconfig and remove mocks, test, stories from buil…
anrusina Apr 28, 2022
bcc03fa
Make whole row clickable to open TaskExecutionDetails panel (#444)
eugenejahn May 2, 2022
a7ac2a1
ci: allow to start jest config for all project at once (#447)
anrusina May 3, 2022
2082f18
minor: unable to view all the workflow versions (#446)
ursucarina May 4, 2022
8dc9487
chore(tsc): exclude test/stories/mock files only from build (#451)
anrusina May 5, 2022
0b70a97
ci: ensure that webpack too doesn't include test/mock/specs files (#452)
anrusina May 6, 2022
dfb1f04
minor: add support for StructuredDataSet Input/Output type (#445)
ursucarina May 6, 2022
23e811d
chore: Provide basic repo structure and ensure that stories, tests, v…
anrusina May 11, 2022
0cc3ed2
ci: minimize babel presence (#457)
anrusina May 11, 2022
cba20f0
fix: update node executions to display map tasks (#455)
olga-union May 13, 2022
540e2e6
ci: resolve docker build issues (#462)
anrusina May 13, 2022
3d176f0
Chore: Rebase devmain on top of master (#464)
anrusina May 13, 2022
5e143c0
fix: ensure that admin version is fully shown (#465)
anrusina May 14, 2022
91881db
chore: fix for console not respecting admin url (#468)
ursucarina May 17, 2022
4e123d9
chore: rebase on top of master
anrusina May 17, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
21 changes: 0 additions & 21 deletions .babelrc

This file was deleted.

1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ module.exports = {
'no-await-in-loop': 'off',
'no-undef-init': 'off',
'no-unneeded-ternary': 'off',
'no-underscore-dangle': 'off',
'prefer-object-spread': 'off',
'prefer-template': 'off',
'default-case': 'off',
Expand Down
6 changes: 2 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ app/public/styles/*.css
.idea
.cache/
venv/
*.tsbuildinfo

# Frontend
.awcache/
Expand All @@ -52,7 +53,4 @@ yarn-error.log

# Certs
.srl
script/rootCA.*
script/server.crt
script/server.csr
script/server.key
certificate/
10 changes: 5 additions & 5 deletions .storybook/StorybookContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import { QueryClientProvider } from 'react-query';
import { MemoryRouter } from 'react-router-dom';
import { SnackbarProvider } from 'notistack';

import { ErrorBoundary } from '../src/components/common/ErrorBoundary';
import { createQueryClient } from '../src/components/data/queryCache';
import { muiTheme } from '../src/components/Theme/muiTheme';
import { LocalCacheProvider } from '../src/basics/LocalCache/ContextProvider';
import { FeatureFlagsProvider } from '../src/basics/FeatureFlags';
import { ErrorBoundary } from '../packages/zapp/console/src/components/common/ErrorBoundary';
import { createQueryClient } from '../packages/zapp/console/src/components/data/queryCache';
import { muiTheme } from '../packages/zapp/console/src/components/Theme/muiTheme';
import { LocalCacheProvider } from '../packages/zapp/console/src/basics/LocalCache/ContextProvider';
import { FeatureFlagsProvider } from '../packages/zapp/console/src/basics/FeatureFlags';

const useStyles = makeStyles((theme: Theme) => ({
container: {
Expand Down
13 changes: 11 additions & 2 deletions .storybook/main.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
var path = require('path');
module.exports = {
core: {
builder: 'webpack5',
},
stories: ['../src/**/*.stories.mdx', '../src/**/*.stories.@(js|jsx|ts|tsx)'],
stories: ['../packages/**/*.stories.@(js|jsx|ts|tsx|mdx)'],
addons: [
'@storybook/addon-links',
'@storybook/addon-essentials',
'@storybook/addon-interactions',
],
framework: '@storybook/react',
webpackFinal: async (config, { configType }) => {
config.resolve.modules = ['src', 'node_modules'];
config.resolve.modules = ['packages/zapp/console/src', 'node_modules'];
config.module.rules = [
...config.module.rules,
{
Expand All @@ -22,6 +23,14 @@ module.exports = {
use: ['babel-loader', { loader: 'ts-loader', options: { transpileOnly: true } }],
},
];

config.resolve.alias = {
...config.resolve.alias,
'@flyteconsole/locale': path.resolve(__dirname, '../packages/basics/locale/src'),
'@flyteconsole/ui-atoms': path.resolve(__dirname, '../packages/composites/ui-atoms/src'),
'@flyteconsole/components': path.resolve(__dirname, '../packages/plugins/components/src'),
};

return config;
},
};
10 changes: 6 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# Use node:17 to docker build on M1
FROM node:16 as builder
LABEL org.opencontainers.image.source https://github.com/lyft/flyteconsole
LABEL org.opencontainers.image.source https://github.com/flyteorg/flyteconsole

WORKDIR /code/flyteconsole
COPY package*.json yarn.lock ./
COPY ./packages/zapp/console/package*.json yarn.lock ./
RUN : \
# install production dependencies
&& yarn install --production \
Expand All @@ -17,10 +18,11 @@ RUN : \
# build
&& make build_prod \
# place the runtime application in /app
&& mv dist index.js env.js plugins.js /app
&& mv ./packages/zapp/console/dist /app \
&& mv ./packages/zapp/console/index.js ./packages/zapp/console/env.js ./packages/zapp/console/plugins.js /app

FROM gcr.io/distroless/nodejs
LABEL org.opencontainers.image.source https://github.com/lyft/flyteconsole
LABEL org.opencontainers.image.source https://github.com/flyteorg/flyteconsole

COPY --from=builder /app app
WORKDIR /app
Expand Down
54 changes: 15 additions & 39 deletions jest.config.js
Original file line number Diff line number Diff line change
@@ -1,45 +1,21 @@
/** @type {import('ts-jest/dist/types').InitialOptionsTsJest} */
const sharedConfig = require('./script/test/jest.base.js');

module.exports = {
globals: {
'ts-jest': {
babelConfig: true,
},
},
...sharedConfig,
clearMocks: true,
verbose: false,
moduleFileExtensions: ['ts', 'tsx', 'js', 'json', 'node'],
modulePaths: ['<rootDir>/src'],
roots: ['<rootDir>/src'],
testPathIgnorePatterns: [
'__stories__',
'<rootDir>/.storybook',
'<rootDir>/node_modules',
'<rootDir>/dist',
'<rootDir>/build',

setupFilesAfterEnv: ['./script/test/jest-setup.ts'],
projects: [
'<rootDir>/packages/basics/locale',
'<rootDir>/packages/composites/ui-atoms',
'<rootDir>/packages/plugins/components',
'<rootDir>/packages/zapp/console',
],
transform: {
'^.+\\.(j|t)sx?$': 'ts-jest',
},
transformIgnorePatterns: ['<rootDir>/node_modules/(?!@flyteorg/flyteidl)'],
moduleNameMapper: {
'\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$':
'<rootDir>/assetsTransformer.js',
},
coverageDirectory: '.coverage',

coverageDirectory: '<rootDir>/.coverage',
collectCoverageFrom: ['**/*.{ts,tsx}', '!**/*/*.stories.{ts,tsx}', '!**/*/*.mocks.{ts,tsx}'],
coveragePathIgnorePatterns: [
'__stories__',
'__mocks__',
'<rootDir>/.storybook',
'<rootDir>/node_modules',
'<rootDir>/dist',
'<rootDir>/build',
'<rootDir>/src/tsd',
'<rootDir>/src/server.ts',
'<rootDir>/.eslintrc.js',
'\\.config.js$',
],
coveragePathIgnorePatterns: [...sharedConfig.coveragePathIgnorePatterns],
coverageReporters: ['text', 'json', 'html'],
clearMocks: true,
setupFiles: ['<rootDir>/node_modules/regenerator-runtime/runtime'],
setupFilesAfterEnv: ['<rootDir>/src/test/setupTests.ts'],
preset: 'ts-jest',
};
Loading