Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release process #529

Merged
merged 4 commits into from
Jun 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,27 @@ jobs:
echo "::set-output name=currentTag::$CURRENT_TAG"

push_docker_image:
name: Build & Push Flyteconsole Image
name: Push to Github Registry
needs: [check_for_tag]
uses: flyteorg/flytetools/.github/workflows/publish.yml@master
with:
version: ${{ needs.check_for_tag.outputs.currentTag }}
dockerfile: Dockerfile
push: true
repository: ${{ github.repository }}
secrets:
FLYTE_BOT_PAT: ${{ secrets.FLYTE_BOT_PAT }}
FLYTE_BOT_USERNAME: ${{ secrets.FLYTE_BOT_USERNAME }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: '0'
- name: Autobump version
env:
TAG: ${{ needs.check_for_tag.outputs.currentTag }}
run: |
VERSION=${TAG:1} make update_npmversion
- name: Push Docker Image to Github Registry
uses: whoan/docker-build-with-cache-action@v5
with:
username: "${{ secrets.FLYTE_BOT_USERNAME }}"
password: evalsocket
image_name: flyteorg/flyteconsole
image_tag: latest,${{ github.sha }},${{ needs.check_for_tag.outputs.currentTag }}
push_git_tag: true
push_image_and_stages: false
dockerfile: Dockerfile
registry: ghcr.io
build_extra_args: "--compress=true"
6 changes: 4 additions & 2 deletions .github/workflows/upgrade_automtion.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
options:
- boilerplate
- flyteidl
- flyteconsole
jobs:
trigger-upgrade:
name: ${{ github.event.inputs.component }} Upgrade
Expand All @@ -23,7 +24,7 @@ jobs:
upgrade_flyteidl:
name: Upgrade Flyteidl
runs-on: ubuntu-latest
if: ${{ github.event.inputs.component == "boilerplate" }}
if: ${{ github.event.inputs.component == "flyteidl" }}
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -47,7 +48,7 @@ jobs:
signoff: true
branch: flyte-bot-update-flyteidl
delete-branch: true
title: 'Update Flyteidl version'
title: "Update Flyteidl version"
body: |
Update Flyteidl version
- Auto-generated by [flyte-bot]
Expand All @@ -57,3 +58,4 @@ jobs:
owners
maintainers
draft: false

8 changes: 1 addition & 7 deletions .releaserc.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,6 @@
],
["@semantic-release/npm", { "npmPublish": false }],
"@semantic-release/github",
[
"@semantic-release/git",
{
"assets": ["package.json", "CHANGELOG.md"],
"message": "chore(release): Release ${nextRelease.version} [skip ci]\n\n${nextRelease.notes}"
}
]
[]
]
}
7 changes: 7 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,10 @@ test_unit_codecov:
.PHONY: generate_ssl
generate_ssl:
./script/generate_ssl.sh

PLACEHOLDER_NPM := \"version\": \"0.0.0-develop\"

.PHONY: update_npmversion
update_npmversion:
grep "$(PLACEHOLDER_NPM)" "packages/zapp/console/package.json"
sed -i "s/$(PLACEHOLDER_NPM)/\"version\": \"${VERSION}\"/g" "packages/zapp/console/package.json"
2 changes: 1 addition & 1 deletion packages/zapp/console/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@flyteconsole/client-app",
"version": "1.1.3",
"version": "0.0.0-develop",
anrusina marked this conversation as resolved.
Show resolved Hide resolved
"description": "The web UI for the Flyte platform",
"repository": {
"type": "git",
Expand Down