chore: fix filters #621
Merged
chore: fix filters #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai> Co-authored-by: Carina Ursu <carina@union.ai>
Signed-off-by: eugenejahn <eugenejahnjahn@gmail.com>
* ci: move storybook related packages to top level * ci: ensure that lint can be run in PR checks * ci: allow to run tests linux setup Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: eugenejahn <eugenejahnjahn@gmail.com>
#436) * ci: ensure unified tsconfig and remove mocks,test,stories from build * ci: move certificates into certificate folder inside script Signed-off-by: Nastya Rusina <nastya@union.ai>
* fix: issue 398 * fix: prevent parent onclick event trigger Signed-off-by: eugenejahn <eugenejahnjahn@gmail.com>
* fix: unable to view all the workflow versions Signed-off-by: Carina Ursu <carina@union.ai> * chore: cleanup Signed-off-by: Carina Ursu <carina@union.ai> Co-authored-by: Carina Ursu <carina@union.ai>
* chore(tsc): exclude test/stories/mock files only from build Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: Nastya Rusina <nastya@union.ai>
* chore: support for StructuredDataSet Input/Output type Signed-off-by: Carina Ursu <carina@union.ai> * chore: add tests Signed-off-by: Carina Ursu <carina@union.ai> * chore: add package Signed-off-by: Carina Ursu <carina@union.ai> * chore: resolving local package issue Signed-off-by: Carina Ursu <carina@union.ai> * chore: yarn lock Signed-off-by: Carina Ursu <carina@union.ai> * chore: stories Signed-off-by: Carina Ursu <carina@union.ai> * chore: fix associative arrays in copy functionality Signed-off-by: Carina Ursu <carina@union.ai> * chore: fix scalar stories Signed-off-by: Carina Ursu <carina@union.ai> * chore: oops Signed-off-by: Carina Ursu <carina@union.ai> * chore: cleanup Signed-off-by: Carina Ursu <carina@union.ai> * chore: revert old viewer to original Signed-off-by: Carina Ursu <carina@union.ai> * chore: fix Signed-off-by: Carina Ursu <carina@union.ai> * chore: remove non-null assertion Signed-off-by: Carina Ursu <carina@union.ai> * chore: fix types Signed-off-by: Carina Ursu <carina@union.ai> * chore: cleanup Signed-off-by: Carina Ursu <carina@union.ai> * chore: fix tests Signed-off-by: Carina Ursu <carina@union.ai> * chore: fix test types Signed-off-by: Carina Ursu <carina@union.ai> * chore: cleanup Signed-off-by: Carina Ursu <carina@union.ai> * chore: cleanup Signed-off-by: Carina Ursu <carina@union.ai> * chore: cleanup Signed-off-by: Carina Ursu <carina@union.ai> * chore: cleanup Signed-off-by: Carina Ursu <carina@union.ai> Co-authored-by: Carina Ursu <carina@union.ai>
…scode setup properly (#458) * chore: separate AppInfo * chore: vscode properly understands @flyteconsole * chore: add basics/locale entry * test: add storybooks and tests * test: fix istanbul test-coverage issue by binding babel versions Signed-off-by: Nastya Rusina <nastya@union.ai>
* ci: minimize babel presence Signed-off-by: Nastya Rusina <nastya@union.ai>
* fix: update node executions to display map tasks * fix: update map task logs styles * test: add/update unit tests * fix: fix flickering and unnecessary re-renders Signed-off-by: Olga Nad <olga@union.ai>
* ci: resolve docker build issues * chore: remove unneeded changes Signed-off-by: Nastya Rusina <nastya@union.ai>
* chore: fix Signed-off-by: Carina Ursu <carina@union.ai> * chore: remove console Signed-off-by: Carina Ursu <carina@union.ai> * chore: add cherio o=to package Signed-off-by: Carina Ursu <carina@union.ai> * chore: add cherio o=to package Signed-off-by: Carina Ursu <carina@union.ai> * chore: fix start prod Signed-off-by: Carina Ursu <carina@union.ai> * chore: fix start prod Signed-off-by: Carina Ursu <carina@union.ai> * chore: cleanup Signed-off-by: Carina Ursu <carina@union.ai> * chore: cleanup Signed-off-by: Carina Ursu <carina@union.ai> Co-authored-by: Carina Ursu <carina@union.ai>
Signed-off-by: Nastya <55718143+anrusina@users.noreply.github.com>
Signed-off-by: Nastya <55718143+anrusina@users.noreply.github.com>
made the entities component become more generic that can support Workflow, Task, and others added the inputs and outputs to task details page added the versions table in task details page added the version details page added task details link in node side panel Signed-off-by: eugenejahn <eugenejahnjahn@gmail.com> Co-authored-by: Eugene Jahn <eugenejahnjahn@gmail.com>
Signed-off-by: Nastya Rusina <nastya@union.ai> Co-authored-by: Nastya Rusina <nastya@union.ai>
* hotfix ci pipeline Signed-off-by: Yuvraj <evalsocket@users.noreply.github.com> * more changes Signed-off-by: Yuvraj <evalsocket@users.noreply.github.com> Co-authored-by: Yuvraj <evalsocket@users.noreply.github.com>
fix: inputHelpers InputProps Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: Carina Ursu <carina@union.ai>
* fix: fix test of launchform Signed-off-by: James <james@union.ai> * fix: inputHelpers tests regression Signed-off-by: Olga Nad <olga@union.ai> * fix: update tests description Signed-off-by: Olga Nad <olga@union.ai> * fix: spelling typo Signed-off-by: Olga Nad <olga@union.ai> Signed-off-by: James <james@union.ai> Signed-off-by: Olga Nad <olga@union.ai> Co-authored-by: Olga Nad <olga@union.ai>
Signed-off-by: Jason Porter <jason@union.ai> Signed-off-by: Jason Porter <jason@union.ai>
Minor change Signed-off-by: Jason Porter <jason@union.ai> Signed-off-by: Jason Porter <jason@union.ai>
…#582) Signed-off-by: Olga Nad <olga@union.ai> Signed-off-by: Olga Nad <olga@union.ai>
Signed-off-by: Flyte-Bot <admin@flyte.org> Signed-off-by: Flyte-Bot <admin@flyte.org> Co-authored-by: flyte-bot <flyte-bot@users.noreply.github.com>
* fix: add BASE_URL to dev startup, open deeply nested urls Signed-off-by: Carina Ursu <carina@union.ai> * fix: remove debug code Signed-off-by: Carina Ursu <carina@union.ai> * chore: empty BASE_URL handling Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: Carina Ursu <carina@union.ai>
* fix: add default disabled state for only mine filter Signed-off-by: Olga Nad <olga@union.ai> * fix: tests Signed-off-by: Olga Nad <olga@union.ai> * fix: use api context to default filter state Signed-off-by: Olga Nad <olga@union.ai> * fix: revert test updates Signed-off-by: Olga Nad <olga@union.ai> Signed-off-by: Olga Nad <olga@union.ai>
Signed-off-by: Flyte-Bot <admin@flyte.org> Signed-off-by: Flyte-Bot <admin@flyte.org> Co-authored-by: flyte-bot <flyte-bot@users.noreply.github.com>
* progress * Fixed * Removed debug code Signed-off-by: Jason Porter <jason@union.ai> Signed-off-by: Jason Porter <jason@union.ai>
chore: enable deeplinks in development Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Jason Porter <jason@union.ai> Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Olga Nad <olga@union.ai>
Signed-off-by: Olga Nad <olga@union.ai>
olga-union
requested review from
a team,
ursucarina,
eugenejahn and
james-union
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## devmain #621 +/- ##
===========================================
+ Coverage 67.35% 67.77% +0.42%
===========================================
Files 398 443 +45
Lines 9296 10526 +1230
Branches 1590 1805 +215
===========================================
+ Hits 6261 7134 +873
- Misses 3035 3392 +357
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jsonporter
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Post-refactor fix of the filters behavior in Table tab view.
Type
Are all requirements met?
Demo
Screen.Recording.2022-10-18.at.4.09.22.PM.mov
Tracking Issue
fixes https://github.com/flyteorg/flyteconsole/issues/617
Follow-up issue
NA