Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content panel captures focus #754

Merged
merged 2 commits into from
May 10, 2023
Merged

fix: content panel captures focus #754

merged 2 commits into from
May 10, 2023

Conversation

ursucarina
Copy link
Contributor

TL;DR

Prevents the content panel from capturing focus away from other modals

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

added disableEnforceFocus to DetailsPanel

Tracking Issue

NA

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina requested review from a team, jsonporter, 4nalog and olga-union and removed request for a team May 10, 2023 20:26
@ursucarina ursucarina enabled auto-merge (squash) May 10, 2023 20:27
@ursucarina ursucarina merged commit 5caa0ab into master May 10, 2023
@ursucarina ursucarina deleted the carina/modal branch May 10, 2023 21:07
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants