Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Commit

Permalink
docs fix
Browse files Browse the repository at this point in the history
Signed-off-by: Yuvraj <code@evalsocket.dev>
  • Loading branch information
yindia committed Jul 1, 2021
1 parent f62639d commit bf750f3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 18 deletions.
2 changes: 1 addition & 1 deletion cmd/register/files.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ SourceUploadPath is an optional flag. By default, flytectl will create SourceUpl
In case of fast registration, If the SourceUploadPath flag is defined then In this case flytectl will not use the default directory for uploading the source code, it will override the destination path on the registration
::
bin/flytectl register file _pb_output/* -d development -p flytesnacks -v v2 --additionalDistributionPath="s3://dummy/fast"
bin/flytectl register file _pb_output/* -d development -p flytesnacks -v v2 --SourceUploadPath="s3://dummy/fast"
Using archive file.Currently supported are .tgz and .tar extension files and can be local or remote file served through http/https.
Use --archive flag.
Expand Down
17 changes: 0 additions & 17 deletions cmd/register/register_util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -313,11 +313,6 @@ func TestFlyteManifest(t *testing.T) {
assert.NotEmpty(t, tag)
}

//func TestGetAdditionalDistributionLoc(t *testing.T) {
// remoteLocation := getRemoteStoragePath("s3://dummy", "test.tar.gz", "v1")
// assert.Equal(t, "s3://dummy/v1-test.tar.gz", string(remoteLocation))
//}

func TestUploadFastRegisterArtifact(t *testing.T) {
t.Run("Successful upload", func(t *testing.T) {
testScope := promutils.NewTestScope()
Expand Down Expand Up @@ -409,15 +404,3 @@ func TestHydrateNode(t *testing.T) {
assert.NotNil(t, err)
})
}

//
//func TestGetAdditionalDistributionPath(t *testing.T) {
// t.Run("s3 config validate", func(t *testing.T) {
// ClientDataStore = nil
// s, err := getRemoteStoragePath(context.Background(),ClientDataStore, &storage.Config{
// InitContainer: "s3-bucket",
// Type: "s3",
// })
// assert.Equal(t, "s3://s3-bucket/fast",Client, )
// })
//}

0 comments on commit bf750f3

Please sign in to comment.