Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Bumped up idl to use insecureVerify flag for remote and fixed docs #125

Merged
merged 3 commits into from
Jul 1, 2021

Conversation

pmahindrakar-oss
Copy link
Contributor

@pmahindrakar-oss pmahindrakar-oss commented Jul 1, 2021

Signed-off-by: Prafulla Mahindrakar prafulla.mahindrakar@gmail.com

TL;DR

Using insecureVerify to disregard the hostname coming in the cert for testing flyte on remote.
Customers can try this initially before productionizing with a CA cert.

Also fixed the docs to included the missing generated files
https://docs.flyte.org/projects/flytectl/en/pmahindrakar-bump-idl/

  • Ingress o/p
kubectl get ingress  -n flyte
Warning: extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
NAME         CLASS    HOSTS   ADDRESS                                                       PORTS   AGE
flyte        <none>   *       k8s-flyte-4e377a65f3-1023371231.us-east-2.elb.amazonaws.com   80      4h33m
flyte-grpc   <none>   *       k8s-flyte-4e377a65f3-1023371231.us-east-2.elb.amazonaws.com   80      4h33m
  • Modified the config.yaml to use the insecureVerify flag

  • Without the flag

flytectl get project
Error: rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: x509: certificate is valid for flyte.example.org, not k8s-flyte-4e377a65f3-1023371231.us-east-2.elb.amazonaws.com"
  • With flag
flytectl get project                            
 --------------- --------------- --------------------------- 
| ID            | NAME          | DESCRIPTION               |
 --------------- --------------- --------------------------- 
| flyteexamples | flyteexamples | flyteexamples description |
 --------------- --------------- --------------------------- 
| flytesnacks   | flytesnacks   | flytesnacks description   |
 --------------- --------------- --------------------------- 
| flytetester   | flytetester   | flytetester description   |
 --------------- --------------- --------------------------- 

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #125 (187d9ae) into master (67c6ff9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   75.17%   75.17%           
=======================================
  Files         105      105           
  Lines        2578     2578           
=======================================
  Hits         1938     1938           
  Misses        527      527           
  Partials      113      113           
Impacted Files Coverage Δ
cmd/sandbox/start.go 77.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c6ff9...187d9ae. Read the comment docs.

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
@pmahindrakar-oss pmahindrakar-oss changed the title Bumped up idl to use insecureVerify flag for remote Bumped up idl to use insecureVerify flag for remote and fixed docs Jul 1, 2021
EngHabu
EngHabu previously approved these changes Jul 1, 2021
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
@pmahindrakar-oss pmahindrakar-oss merged commit bf60ec1 into master Jul 1, 2021
@pmahindrakar-oss pmahindrakar-oss deleted the pmahindrakar/bump-idl branch July 1, 2021 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants