Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Upgrade IDL version #382

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Upgrade IDL version #382

merged 1 commit into from
Feb 2, 2023

Conversation

pmahindrakar-oss
Copy link
Contributor

Signed-off-by: pmahindrakar-oss prafulla.mahindrakar@gmail.com

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #382 (90f59ee) into master (b0d9893) will increase coverage by 0.68%.
The diff coverage is n/a.

❗ Current head 90f59ee differs from pull request most recent head 9c6b912. Consider uploading reports for the commit 9c6b912 to get more accurate results

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   66.88%   67.57%   +0.68%     
==========================================
  Files         144      144              
  Lines        6166     5150    -1016     
==========================================
- Hits         4124     3480     -644     
+ Misses       1776     1404     -372     
  Partials      266      266              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/get/matchable_workflow_execution_config.go 37.20% <0.00%> (-8.95%) ⬇️
cmd/delete/matchable_attribute_util.go 54.16% <0.00%> (-4.46%) ⬇️
cmd/update/matchable_attribute_util.go 56.00% <0.00%> (-4.00%) ⬇️
cmd/core/cmd_ctx.go 58.82% <0.00%> (-2.29%) ⬇️
cmd/register/examples.go 93.75% <0.00%> (-1.71%) ⬇️
cmd/get/matchable_attribute_util.go 73.68% <0.00%> (-1.32%) ⬇️
cmd/root.go 47.54% <0.00%> (-1.27%) ⬇️
cmd/update/named_entity.go 89.28% <0.00%> (-1.04%) ⬇️
cmd/create/execution.go 93.93% <0.00%> (-0.94%) ⬇️
pkg/filters/util.go 72.72% <0.00%> (-0.81%) ⬇️
... and 124 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pmahindrakar-oss pmahindrakar-oss enabled auto-merge (squash) February 2, 2023 14:22
@pmahindrakar-oss pmahindrakar-oss merged commit 50bc5a9 into master Feb 2, 2023
@pmahindrakar-oss pmahindrakar-oss deleted the upgrade-idl branch February 2, 2023 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants