Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Remove go as dependency of brew formula #395

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

honnix
Copy link
Member

@honnix honnix commented Mar 6, 2023

TL;DR

Remove go as dependency of brew formula

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Since we are pulling the built binary, go shouldn't be needed.

Tracking Issue

Closes flyteorg/flyte#3406

Follow-up issue

NA

Signed-off-by: Honnix <honnix@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #395 (fef8003) into master (5aefa07) will increase coverage by 0.80%.
The diff coverage is 100.00%.

❗ Current head fef8003 differs from pull request most recent head 9595ab2. Consider uploading reports for the commit 9595ab2 to get more accurate results

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   66.54%   67.34%   +0.80%     
==========================================
  Files         145      145              
  Lines        6265     5234    -1031     
==========================================
- Hits         4169     3525     -644     
+ Misses       1816     1429     -387     
  Partials      280      280              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/get/node_execution.go 81.67% <100.00%> (+2.43%) ⬆️
cmd/get/matchable_workflow_execution_config.go 37.20% <0.00%> (-8.95%) ⬇️
cmd/delete/matchable_attribute_util.go 54.16% <0.00%> (-4.46%) ⬇️
cmd/update/matchable_attribute_util.go 56.00% <0.00%> (-4.00%) ⬇️
cmd/core/cmd_ctx.go 58.82% <0.00%> (-2.29%) ⬇️
cmd/register/examples.go 93.75% <0.00%> (-1.71%) ⬇️
cmd/get/matchable_attribute_util.go 73.68% <0.00%> (-1.32%) ⬇️
cmd/root.go 47.54% <0.00%> (-1.27%) ⬇️
cmd/update/named_entity.go 89.28% <0.00%> (-1.04%) ⬇️
cmd/create/execution.go 93.93% <0.00%> (-0.94%) ⬇️
... and 125 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eapolinario eapolinario merged commit a6b856a into flyteorg:master Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] homebrew formula unnecessarily depends on go
2 participants