Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

When preleases are allowed for demo sandbox, simply choose the latest release #407

Merged
merged 1 commit into from
May 28, 2023

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented May 28, 2023

TL;DR

When running flytectl demo start --pre, the correct behavior should be to choose the latest version, regardless of whether it corresponds to a pre-release.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

… release

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #407 (6229740) into master (5cb23b7) will increase coverage by 0.77%.
The diff coverage is 100.00%.

❗ Current head 6229740 differs from pull request most recent head a372936. Consider uploading reports for the commit a372936 to get more accurate results

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   66.60%   67.37%   +0.77%     
==========================================
  Files         145      145              
  Lines        6273     5239    -1034     
==========================================
- Hits         4178     3530     -648     
+ Misses       1815     1429     -386     
  Partials      280      280              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/github/githubutil.go 63.30% <100.00%> (+2.99%) ⬆️

... and 133 files with indirect coverage changes

Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for fishing this!

@jeevb jeevb merged commit e5e63ba into master May 28, 2023
@jeevb jeevb deleted the jeev/prerelease-behavior branch May 28, 2023 04:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants