Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Update typo nodID -> nodeID in execution.go, flytectl_get_execution.rst #none #450

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

guy4261
Copy link
Contributor

@guy4261 guy4261 commented Dec 20, 2023

TL;DR

The usage examples for flytectl get was broken because nodeID was replaced with nodID (no e). I fixed it.

Type

  • Bug Fix

Are all requirements met?

It's just a typo fix, all are irrelevant afaik.

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

I fixed a typo :)

Tracking Issue

NA

Follow-up issue

NA

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b49071) 67.69% compared to head (e18d825) 67.69%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #450   +/-   ##
=======================================
  Coverage   67.69%   67.69%           
=======================================
  Files         148      148           
  Lines        6622     6622           
=======================================
  Hits         4483     4483           
  Misses       1851     1851           
  Partials      288      288           
Flag Coverage Δ
unittests 67.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 9c87165 into flyteorg:master Feb 10, 2024
14 of 15 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants