Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Generate config_flags for http proxy #411

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ByronHsu
Copy link
Contributor

TL;DR

In #405, I somehow missed a piece when generating. This pr i do make generate, and add it back.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Signed-off-by: byhsu <byhsu@linkedin.com>
@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #411 (da776e6) into master (e718afd) will increase coverage by 2.55%.
The diff coverage is n/a.

❗ Current head da776e6 differs from pull request most recent head db595dc. Consider uploading reports for the commit db595dc to get more accurate results

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   75.92%   78.48%   +2.55%     
==========================================
  Files          18       18              
  Lines        1458     1250     -208     
==========================================
- Hits         1107      981     -126     
+ Misses        294      212      -82     
  Partials       57       57              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

@hamersaw
Copy link
Contributor

hamersaw commented Jun 1, 2023

@wild-endeavor was this fixed by another PR? Can we close this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants