Execution model fields #1164
Merged
Execution model fields #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
katrogan
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
wild-endeavor
previously approved these changes
Sep 15, 2022
flytekit/models/execution.py
Outdated
| return _execution_pb2.SystemMetadata(execution_cluster=self.execution_cluster) | ||
|
|
||
| @classmethod | ||
| def from_flyte_idl(cls, pb2_object) -> SystemMetadata: |
There was a problem hiding this comment.
Suggested change
| def from_flyte_idl(cls, pb2_object) -> SystemMetadata: | |
| def from_flyte_idl(cls, pb2_object: flyteidl.admin.execution_pb2.SystemMetadata) -> SystemMetadata: |
flytekit/models/execution.py
Outdated
| @classmethod | ||
| def from_flyte_idl(cls, pb2_object) -> SystemMetadata: | ||
| """ | ||
| :param flyteidl.admin.execution_pb2.SystemMetadata pb2_object: |
There was a problem hiding this comment.
copy pasta, thanks
flytekit/models/execution.py
Outdated
| mode: int, | ||
| principal: str, | ||
| nesting: int, | ||
| scheduled_at: datetime.datetime = None, |
There was a problem hiding this comment.
Suggested change
| scheduled_at: datetime.datetime = None, | |
| scheduled_at: typing.Optional[datetime.datetime] = None, |
and the other three?
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
==========================================
+ Coverage 68.51% 68.52% +0.01%
==========================================
Files 288 288
Lines 26085 26192 +107
Branches 2918 2924 +6
==========================================
+ Hits 17871 17947 +76
- Misses 7735 7766 +31
Partials 479 479
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wild-endeavor
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katrina Rogan katroganGH@gmail.com
TL;DR
Updates ExecutionClosure with optional AbortMetadata and ExecutionMetadata with the complete set of fields
Type
Are all requirements met?
Complete description
User requested feature
Tracking Issue
flyteorg/flyte#2881
Follow-up issue
NA