Add support chain multiple tasks #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
wild-endeavor,
kumare3 and
eapolinario
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1222 +/- ##
=======================================
Coverage 68.57% 68.58%
=======================================
Files 288 288
Lines 26225 26232 +7
Branches 2929 2929
=======================================
+ Hits 17985 17992 +7
Misses 7762 7762
Partials 478 478
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kumare3
reviewed
Oct 6, 2022
| @@ -678,6 +679,7 @@ def ref(self) -> NodeOutput: | |||
| def __rshift__(self, other: typing.Union[Promise, VoidPromise]): | |||
| if self.ref: | |||
| self.ref.node.runs_before(other.ref.node) | |||
| return other | |||
kumare3
approved these changes
Oct 6, 2022
eapolinario
approved these changes
Oct 6, 2022
wild-endeavor
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Su pingsutw@apache.org
TL;DR
Add support chain multiple tasks by returning
otherwhen calling rshiftType
Are all requirements met?
Complete description
Tracking Issue
flyteorg/flyte#2955
Follow-up issue
NA