Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of image stanza in pyflyte register and other small changes #1227

Merged
merged 5 commits into from
Oct 7, 2022

Conversation

eapolinario
Copy link
Collaborator

TL;DR

pyflyte register is now able to load images present in the config file. That sub-command also requires a version in non-fast case.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Changes to pyflyte register:

  1. The output of the command now is more explicit about which serialization settings are used, which include the images allowed to be used.
  2. Force version in non fast. The idea is to make it clear that this option requires the user to be deliberate about versions when registering entities using the non-fast option.
  3. Allow for images present in a config file to be used during registration

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario changed the title Enable use of images stanza in pyflyte register and other small changes Enable use of image stanza in pyflyte register and other small changes Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #1227 (5cfbcea) into master (63ad4fc) will increase coverage by 0.05%.
The diff coverage is 91.11%.

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
+ Coverage   68.57%   68.63%   +0.05%     
==========================================
  Files         288      288              
  Lines       26224    26279      +55     
  Branches     2929     2935       +6     
==========================================
+ Hits        17984    18036      +52     
- Misses       7762     7764       +2     
- Partials      478      479       +1     
Impacted Files Coverage Δ
flytekit/clis/sdk_in_container/register.py 79.68% <62.50%> (-3.08%) ⬇️
flytekit/clis/sdk_in_container/helpers.py 92.59% <92.85%> (-0.27%) ⬇️
flytekit/clis/sdk_in_container/run.py 84.05% <100.00%> (-0.15%) ⬇️
tests/flytekit/unit/cli/pyflyte/test_register.py 100.00% <100.00%> (ø)
flytekit/core/type_engine.py 59.38% <0.00%> (ø)
tests/flytekit/unit/core/test_serialization.py 93.20% <0.00%> (ø)
tests/flytekit/unit/core/test_type_engine.py 98.43% <0.00%> (+0.03%) ⬆️
tests/flytekit/unit/core/test_node_creation.py 95.79% <0.00%> (+0.07%) ⬆️
flytekit/core/promise.py 51.95% <0.00%> (+0.17%) ⬆️
flytekit/core/node.py 53.76% <0.00%> (+0.50%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

wild-endeavor
wild-endeavor previously approved these changes Oct 6, 2022
flytekit/clis/sdk_in_container/register.py Outdated Show resolved Hide resolved
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario merged commit ea1437a into master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants