Set reasonable defaults for pandas dataframe default renderer #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eapolinario
requested review from
wild-endeavor,
kumare3 and
pingsutw
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1238 +/- ##
=======================================
Coverage 68.68% 68.68%
=======================================
Files 288 288
Lines 26323 26333 +10
Branches 2939 2942 +3
=======================================
+ Hits 18079 18087 +8
- Misses 7766 7768 +2
Partials 478 478
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pingsutw
previously approved these changes
Oct 17, 2022
wild-endeavor
previously approved these changes
Oct 17, 2022
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
dismissed stale reviews from wild-endeavor and pingsutw
via
58c4236
wild-endeavor
approved these changes
Oct 18, 2022
VPraharsha03
pushed a commit
to VPraharsha03/flytekit
that referenced
this pull request
Oct 29, 2022
…rg#1238) * Set reasonable defaults for pandas dataframe default renderer * Remove erroneous use of Optional Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Vivek Praharsha <vpraharsha@outlook.com>
kiliangojek
pushed a commit
to kiliangojek/flytekit
that referenced
this pull request
Nov 15, 2022
…rg#1238) * Set reasonable defaults for pandas dataframe default renderer * Remove erroneous use of Optional Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Kilian <kilian.tep@go-jek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
pandas dataframe default renderer should be cheap to render
Type
Are all requirements met?
Complete description
The default deck renderer for pandas dataframes relies on pandas dataframe to_html, but big dataframes take a long time to return, so in this PR we set reasonable defaults for both the max number of rows and columns.
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/